Topics

C#•6mo ago

Update configuration in memory

I have the class below where I'm trying to provide default values if a user doesn't configure them in appsettings. Supposedly, this is supposed to work, but it's not working in practices. Do you have any recommendations to either fix this, or to just use default values regardless and screw the config?

c#
  public static class MainelyLog {
    private readonly static IConfigurationRoot _configuration;
    private readonly static string _appDirectory = AppDomain.CurrentDomain.BaseDirectory;

    static MainelyLog() {
      _configuration = new ConfigurationBuilder()
        .SetBasePath(_appDirectory)
        .AddJsonFile("appsettings.json", optional: false, reloadOnChange: true)
        .Build();
    }

    public static void SetupLogging(string defaultLogPath) {
      IConfigurationSection? logConfig = _configuration.GetSection("Serilog:WriteTo")
        .GetChildren()
        .FirstOrDefault(c => c["Name"] == "File");

      if (logConfig != null && !Path.IsPathFullyQualified(logConfig["Args:path"])) {
        string logPath = logConfig["Args:path"] ?? defaultLogPath;
        if (logPath.StartsWith(".\\")) { logPath = logPath[2..]; }
        logConfig["Args:path"] = Path.Combine(_appDirectory, logPath);
      }

      Log.Logger = new LoggerConfiguration()
      .ReadFrom.Configuration(_configuration)
      .CreateLogger();
    }
  }

c#
  public static class MainelyLog {
    private readonly static IConfigurationRoot _configuration;
    private readonly static string _appDirectory = AppDomain.CurrentDomain.BaseDirectory;

    static MainelyLog() {
      _configuration = new ConfigurationBuilder()
        .SetBasePath(_appDirectory)
        .AddJsonFile("appsettings.json", optional: false, reloadOnChange: true)
        .Build();
    }

    public static void SetupLogging(string defaultLogPath) {
      IConfigurationSection? logConfig = _configuration.GetSection("Serilog:WriteTo")
        .GetChildren()
        .FirstOrDefault(c => c["Name"] == "File");

      if (logConfig != null && !Path.IsPathFullyQualified(logConfig["Args:path"])) {
        string logPath = logConfig["Args:path"] ?? defaultLogPath;
        if (logPath.StartsWith(".\\")) { logPath = logPath[2..]; }
        logConfig["Args:path"] = Path.Combine(_appDirectory, logPath);
      }

      Log.Logger = new LoggerConfiguration()
      .ReadFrom.Configuration(_configuration)
      .CreateLogger();
    }
  }

The purpose of doing this is to account for relative paths not being correct when running interactively vs as a service.

37 Replies

engineertdogOP•6mo ago

Optionally, maybe an easier route is to correctly set the base directory for the app. If running as a Windows service sets it to C:\Windows\system32, then I could set the base directory to the executable directory?

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

So, I did that. But even though the ContentRoot is set correctly, it still has the app base set to C:\windows\system32 which messes up the relative paths. I worked around that by doing this.

c#
if (!Environment.UserInteractive) {
  // Setup Windows Service
  builder.Services.AddWindowsService();
  Directory.SetCurrentDirectory(AppContext.BaseDirectory); // in theory, this line shouldn't be needed, but apparently it is
}

// Logging
MainelyLog.SetupLogging(builder.Configuration);
builder.Services.AddLogging(loggingBuilder => {
  loggingBuilder.AddSerilog(dispose: true);
});

c#
if (!Environment.UserInteractive) {
  // Setup Windows Service
  builder.Services.AddWindowsService();
  Directory.SetCurrentDirectory(AppContext.BaseDirectory); // in theory, this line shouldn't be needed, but apparently it is
}

// Logging
MainelyLog.SetupLogging(builder.Configuration);
builder.Services.AddLogging(loggingBuilder => {
  loggingBuilder.AddSerilog(dispose: true);
});

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

Sets the content root to AppContext.BaseDirectory. For more information, see the Current directory and content root section.

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

No, that's what it says .AddWindowsService() does. Which - is correct. ContentRoot is correct. But the app directory isn't

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

I can't share the repo, it's internal

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

But I can do this

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

I extracted out everything and made a simple app on my local system. Windows 11 & server 2022 are fine. Same configuration on Windows 2019 appears to be where it defaults to system32 still. @TeBeCo

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

Nah, ran the same command. Just a simple sc.exe create <name> binpath= ""

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

These are also likely heavily modified OS's from the cyber security team

MODiX•6mo ago

TeBeCo

might have miss configured the service itself when you did sc create or something

Quoted by

<@689473681302224947> from #Update configuration in memory (click here)

React with ❌ to remove this embed.

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

Yeah, well at least my sanity is straight now. I appreciate it

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

If I get some time, I'll get virtualbox up and test a clean 2019 iso

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

Otherwise it's all the mods they do on the images. But even at that, I'm fine with having 1 extra lina of code (well, 2 extra lines for adding the if statement that's not really required).

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

Wait, I lied. I actually forgot to remove that line.

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

I'll have the code in 1 sec

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

I was, but I actually went with Quartz for scheduling. So it's similar but different https://gitlab.com/engineertdog/windows-service-directory

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

You'd do just a plain console app with the scheduled services, or use something other than Quartz?

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

Yeah, I just started with the worker template but changed to a cron based schedule for running it

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

engineertdogOP•6mo ago

Yeah, it just doesn't seem to be setting the current directory. But one line of code to fix that is not a big deal

Unknown User•6mo ago

Message Not Public

Sign In & Join Server To View

We are a programming server aimed at coders discussing everything related to C# (CSharp) and .NET.

54KMembers

View on Discord

Want results from more Discord servers?

Add your server