#1023: fix: update button state on successful login and signup
Issue #1023 by vinayak-vohra
fix: update button state on successful login and signup
Pull Request Details
Description
Moved the
setbtnState() from catch block to finally block thus updating the button state in both success and error flows.
Fixes
fixes #939
Type of PR
- [x] Bug fix
- [ ] Feature enhancement
- [ ] Documentation update
- [ ] Refactoring
- [ ] Other (specify): ___
Checklist
- [x] I have read and followed the Pull Requests and Issues guidelines.
- [ ] The code has been properly linted and formatted using npm run lint:fix and npm run format:fix.
- [x] I have tested the changes thoroughly before submitting this pull request.
- [x] I have provided relevant issue numbers, snapshots, and videos after making the changes.
- [x] I have not borrowed code without disclosing it, if applicable.
- [x] This pull request is not a Work In Progress (WIP), and only completed and tested changes are included.
- [x] I have tested these changes locally.
- [x] My code follows the project's style guidelines.
- [ ] I have updated the documentation accordingly.
- [x] This PR has a corresponding issue in the issue tracker.
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
Summary by CodeRabbit
- Bug Fixes
- Improved reliability of login and signup button states by ensuring they reset correctly regardless of the outcome.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->0 Replies