Java Community | Help. Code. Learn.•9mo ago

need to handle it when the stock is null

get an error when the stock is 0 but not sure how to fix it java.lang.NullPointerException: Cannot invoke "com.example.todoappdeel3.models.OrderProduct.getQuantity()" because "orderProduct" is null

4 Replies

JavaBot•9mo ago

⌛ This post has been reserved for your question.

Hey @timo! Please use /close or the Close Post button above when your problem is solved. Please remember to follow the help guidelines. This post will be automatically closed after 300 minutes of inactivity.

TIP: Narrow down your issue to simple and precise questions to maximize the chance that others will reply in here.

TimoOP•9mo ago

  @Transactional
    public RetourDTO createRetour(RetourDTO retourDTO, String userName) {
        final CustomUser customUser = userRepository.findByEmail(userName).orElseThrow();

        final Order order = orderRepository.findById(retourDTO.getOrderId()).orElseThrow();
        final Product product = productRepository.findById(retourDTO.getOrderProductId()).orElseThrow();

        // if the order does not exist -> error
        // if item not in order -> error
        final OrderProduct orderProduct = orderProductRepository.findByOrderAndProduct(order, product);

        // decrement item quantity
        if(orderProduct.getQuantity() > 0) orderProduct.setQuantity(orderProduct.getQuantity() - 1);

        // create retour
        final Retour retour = Retour
            .builder()
            .order(order)
            .status("placed")
            .customUser(customUser)
            .reason(retourDTO.getReason())
            .product(orderProduct.getProduct())
            .date(LocalDate.now())
            .build();
        retourRepository.save(retour);
        orderProductRepository.save(orderProduct);

        if(orderProduct.getQuantity() == 0) {
            order.getOrderProducts().remove(orderProduct);
            orderProductRepository.delete(orderProduct);
        }

        // if no items in order, then delete order
        if(order.getOrderProducts().isEmpty()) {
            // orderRepository.delete(order);
            order.setStatus("retour and empty");
            orderRepository.save(order);
        }

        return retour.getDto();
    }

  @Transactional
    public RetourDTO createRetour(RetourDTO retourDTO, String userName) {
        final CustomUser customUser = userRepository.findByEmail(userName).orElseThrow();

        final Order order = orderRepository.findById(retourDTO.getOrderId()).orElseThrow();
        final Product product = productRepository.findById(retourDTO.getOrderProductId()).orElseThrow();

        // if the order does not exist -> error
        // if item not in order -> error
        final OrderProduct orderProduct = orderProductRepository.findByOrderAndProduct(order, product);

        // decrement item quantity
        if(orderProduct.getQuantity() > 0) orderProduct.setQuantity(orderProduct.getQuantity() - 1);

        // create retour
        final Retour retour = Retour
            .builder()
            .order(order)
            .status("placed")
            .customUser(customUser)
            .reason(retourDTO.getReason())
            .product(orderProduct.getProduct())
            .date(LocalDate.now())
            .build();
        retourRepository.save(retour);
        orderProductRepository.save(orderProduct);

        if(orderProduct.getQuantity() == 0) {
            order.getOrderProducts().remove(orderProduct);
            orderProductRepository.delete(orderProduct);
        }

        // if no items in order, then delete order
        if(order.getOrderProducts().isEmpty()) {
            // orderRepository.delete(order);
            order.setStatus("retour and empty");
            orderRepository.save(order);
        }

        return retour.getDto();
    }

let me know if you have any questions 🙂

dan1st•9mo ago

I guess that findByOrderAndProduct returns null

JavaBot•9mo ago

💤 Post marked as dormant

This post has been inactive for over 300 minutes, thus, it has been archived. If your question was not answered yet, feel free to re-open this post or create a new one. In case your post is not getting any attention, you can try to use /help ping. Warning: abusing this will result in moderative actions taken against you.

Gaming

Programming

need to handle it when the stock is null

Did you find this page helpful?