C#•7mo ago

✅ null error, not sure how to fix

60 Replies

Eve.OP•7mo ago

@Pobiega

Pobiega•7mo ago

Yeah, you can't do that. Strings in C# are immutable Meaning you need to produce a new string

Eve.OP•7mo ago

oh in the RemoveExclaimation or in the main

Pobiega•7mo ago

Former

Eve.OP•7mo ago

where is that i thought turning it into an array would help

thegu5•7mo ago

make the userinput a char array, then give that char array to the function

Eve.OP•7mo ago

i thought i did that

Pobiega•7mo ago

thats also a bad idea. your input is a string. The "law of least surprise" says that your output should be a string without exclamations

Eve.OP•7mo ago

i produced a new string

Eve.OP•7mo ago

however i think i've done it wrong

Pobiega•7mo ago

correct also, setting it to a space isnt the same as removing it do you just want to replace the ! with or do you want a string without ! in it?

Eve.OP•7mo ago

i want to remove it

Pobiega•7mo ago

okay

Eve.OP•7mo ago

but i thought i had to replace it to do that

Pobiega•7mo ago

then you need to build a new string you needed to do that before too, to be clear since strings are immutable

Eve.OP•7mo ago

that means it can't change doesnt it

Pobiega•7mo ago

correct

Eve.OP•7mo ago

i've done this before and it worked

Eve.OP•7mo ago

Pobiega•7mo ago

ToCharArray() it converts the string to a char[] but an array is fixed-size! that means you cant remove an item from it, just clear it so !!hello!! would become hello not hello

Eve.OP•7mo ago

right okay so have i done this completely wrong

Pobiega•7mo ago

Well, depends on what your goal was Most people would expect you to take a string in and return a new string

Eve.OP•7mo ago

my goal is to remove the !

Pobiega•7mo ago

Fully remove, right?

Eve.OP•7mo ago

yes

Pobiega•7mo ago

Not just replace Ok

Eve.OP•7mo ago

Pobiega•7mo ago

There is a class called StringBuilder It's very commonly used when you need to "build" a string

Eve.OP•7mo ago

okay ill make it now

Eve.OP•7mo ago

you mean like this

Pobiega•7mo ago

Haha, no there already is one in .NET You don't need to make your ow

Eve.OP•7mo ago

oh okay

Eve.OP•7mo ago

Pobiega•7mo ago

Yup Now change the code to use the string builder

Eve.OP•7mo ago

im not sure what string builder does exactly

Pobiega•7mo ago

on a new row, type sb. and see what pops up

Eve.OP•7mo ago

Pobiega•7mo ago

see that list of things? scroll through it so far, Append is a very good method suggestion

Eve.OP•7mo ago

there is remove

Pobiega•7mo ago

the idea is that you progressively build a copy of the original string, but when you encounter a !, you DONT add it or that, copy the entire string and remove ! but I prefer the first approach

Eve.OP•7mo ago

okay ive used append what does it do?

Pobiega•7mo ago

what do you think? with that name

Eve.OP•7mo ago

fix?

Pobiega•7mo ago

we have a class called StringBuilder. it builds strings, right?

Eve.OP•7mo ago

oh build

Pobiega•7mo ago

what does append mean, in english? it means "to add at the end"

Eve.OP•7mo ago

i did not know that

Pobiega•7mo ago

now you do 🙂

Eve.OP•7mo ago

you're teaching me coding and english

Pobiega•7mo ago

When do I get my teaching license? :d

Eve.OP•7mo ago

soon right so ive put

Eve.OP•7mo ago

Pobiega•7mo ago

static string RemoveExclamations(string input)
{
    var sb = new StringBuilder();

    foreach (char c in input)
    {
        // Eve - your code here.
    }

    return sb.ToString();
}

static string RemoveExclamations(string input)
{
    var sb = new StringBuilder();

    foreach (char c in input)
    {
        // Eve - your code here.
    }

    return sb.ToString();
}

maybe start over from here you have a bunch of old code that doesnt belong and is just confusing you

Eve.OP•7mo ago

okay ive changed it

Pobiega•7mo ago

also, if you prefer, we could go to a voice channel and screen share

Eve.OP•7mo ago

okay lets do that

Pobiega•7mo ago

#vc-1

Eve.OP•7mo ago

i've got 2 exams on monday, so im going to revise the othe for the rest of the night, but will be back to computer science tomorrow @Pobiega

Pobiega•7mo ago

bah stop being sensible 😄 good luck!

Gaming

Programming

✅ null error, not sure how to fix