86 Replies
Hello @Hiyshhiysh! Someone will help you shortly, please do not ping moderators or other people and just wait for someone to come help.
!!logs
How to post your logs to get help
When requesting support for a crash or other error, you should provide error logs - this will give us the information we'll need to help you.
You can find logs in the
logs folder or crash-reports folder of your instance's directory. Latest.log files may contain more information than crash reports.
Please make sure to upload these logs to a paste site instead of uploading the file directly. Type !!paste for a list of sites you can use.
Do not copy and paste, screenshot, or significantly alter your logs.
Where to find your logs:
» Windows/Linux
» macOS
Credit to the Fabric Community discord for these instructions.oop yep
Log File
Environment info
Minecraft Version
1.20.1Mod Loader
Forge (47.2.0)Errors
48​
​
Warnings
882here
Paste created of
latest.log, uploaded by _1696_.Hm I'll look into it later today
May be to do with the fact i'm using interactive
oka
Could be that
Try without interactive on another world
okay
new curseforge instance time ig
just launching the game now
doesn't crash without interactive
now to try it with interactive
This should probably be reported to them then if it occurs with interactive
Since they make a quite large changes to the underlying system
okay
I assume its the VS server
Yep
I'm sorry but what 💀
top 10 piracy!!!
anyway
loading the game
Yeah they don't publish to curseforge
ik
so some other goofball decided to reupload it
which i'm pretty sure violates A LOT of TOS rules
why not?
Dunno
But my best guess would be because cf is a pain to upload to
yeah ig
Their api is iffy and the site is buggy for devs
ye
anyway
I tested it
interactive isn't the issue
guess I'll just start adding more of those mods until I get the crash
found this in the log btw
may be related to the issue
but idk
Yeah that doesn't tell much apart from the tag being null which shouldn't happen normally
hmmmm
okay
what is the StackTag btw?
is it the conductor id
or
It's the tag for the conductor info or smt iirc
I don't remember off the top of my head sadly
okay
could be an issue with binding it whilst it is on an interactive train
I will try that now
interactive works by having the actual blocks tens of millions of blocks away from the train, which could cause all sorts of issues
nope not that
uh
it corrupts the world btw
:thinky:
I'll have a look later today then
okay
i'll continue trying to find which mod it is
hmmmmm
tried again and no crash
hmmmmmmmmm
can't replicate
AHA found the issue
I accidentally put an unbound whistle in the deployer XD
thats why it had no data
still though
pretty serious
Yeah will take a look
cool
:kekw:
Lol that's my bad
I added that feature
But I never thought to test with an unbound whistle
Hence I never thought to add a null check for it
I'll add one later today lol
Not if I beat you to it :p
lol
uh
:thinky:
yeah it's not crashing in dev
maybe it just wasn't on the 1.20.1 branch? this is 1.19
lemme check
nope, it's still there
Show the location that the stack trace Blames
I mean the .string part
Where it actually is run in the mixin
wait is that in the mixin?
what mixin is that?
search for
autoWhistle(
And look for the one in a mixinfound it
MixinStationBlock
Just slap a null check there and it should be good
...which has errors? wut?
ye
on 1.19, right? and then pull to 1.20?
Yeah
that's what's there already
:Confused:
you and me both
I'll have a look later today
can you link the line?
sure, lemme find it on the github
GitHub
Railway/common/src/main/java/com/railwayteam/railways/mixin/MixinSt...
Official repository of the Create Railways mod for Minecraft - Layers-of-Railways/Railway
ayy I replicated the crash
me too
and fixed it?
oh?
seemingly
what'd you do?
huh
I thought setReturnValue would return on it's own
apparently not
this makes it seem like it already cancels it
not really sure why it does that
gonna commit the fix tho
also-
do we need to add a return for any other cir's that don't return?
yeah that's what I was gonna ask
or no
@IThundxr you probably know
I was gonna ask if we should add cir's to returns elsewhere in that mixin
I'm gonna have to look at the Mixin Java docs
ty
setReturnValue should cancel
yeah
yeah
but like
it doesn't?
gonna check rq
Ok
setReturnValue cancels the target method
Not your method
ah
yeah
Add a return; under it
cool
we should do the same for any other places like that
Yeah I'll take a look at where this is needed
Some places shouldn't cancel their own method but some should
yeah
they set the return for the injected-into method, they don't make your mixin method return. I'm generally careful to make sure my control flow is correct, so hopefully my mixins shouldn't have this issue
Yeah. I haven't done a lot of work with mixins before writing that code so I just wasn't aware of that detail.