UB
Universal Blue•8mo ago
M2

For bluefin tags. Looks like we lost

For bluefin tags. Looks like we lost adding the tags to the bash array. https://github.com/ublue-os/bluefin/actions/runs/8605061498/job/23580493765#step:8:20
14 Replies
bsherman
bsherman•8mo ago
oh?
M2
M2OP•8mo ago
Yeah, we had a matrix variable previously it loos like that is not present anymore
bsherman
bsherman•8mo ago
which one?
M2
M2OP•8mo ago
matrix.is_latest_version matrix.is_stable_version
bsherman
bsherman•8mo ago
that got moved
M2
M2OP•8mo ago
Yes but it's referring to matrix.name instead of the variable name.
bsherman
bsherman•8mo ago
instead of a matrix variable being used only to setup bash vars in the single "tags" step, its now a conditional in the "tags" step
M2
M2OP•8mo ago
https://github.com/ublue-os/bluefin/actions/runs/8604817085/job/23579734249#step:8:37 As you can see it's being compared against an empty string. ${{ matrix.is_latest_version }} is empty
bsherman
bsherman•8mo ago
ok, yeah, that's a bug 🙂 c'mon on thought you reviewed my PR 😉
M2
M2OP•8mo ago
Yepp. I'm fixing right now
bsherman
bsherman•8mo ago
thanks!
M2
M2OP•8mo ago
Since we are in bash run right here. I can just use the bash variable name
bsherman
bsherman•8mo ago
it should be clear, since the bash vars map to the old matrix vars thank you for catching this
M2
M2OP•8mo ago
Want results from more Discord servers?
Add your server