@kflansburg is there a specific reason
@kflansburg is there a specific reason you removed this re-export in PR 481?
11 Replies
It breaks usage of
ScheduledEventHere's a PR with a fix: https://github.com/cloudflare/workers-rs/pull/501
GitHub
fix: add schedule re-export by avsaase · Pull Request #501 · cloudf...
I think this was erroneously removed in #481.
Unknown User•8mo ago
Message Not Public
Sign In & Join Server To View
No worries. It happens.
Mistakes like this could be caught by tools like
cargo-semver-checks. They provide github actions to automate these checks.Unknown User•8mo ago
Message Not Public
Sign In & Join Server To View
Yes that's true but in this case the tool would have made it clear that some previously accessible types where not accessible anymore.
I haven't checked yet what the exact CI setup should be to make this work.
Unknown User•8mo ago
Message Not Public
Sign In & Join Server To View
What I would try to do is build and ideally run the examples in CI
Unknown User•8mo ago
Message Not Public
Sign In & Join Server To View
Looks like the pr checks don't run on the release PR
Unknown User•8mo ago
Message Not Public
Sign In & Join Server To View