37 Replies
is this really all that's needed?
seems like we are missing
/usr/etc/profile.d/brew.shthat's in
etc-profile.d
however M2 had some good suggestions: https://discord.com/channels/1072614816579063828/1072617059265032342/1221424564098039901
I think we're missing this from the SPEC yeahi just commented on PR, but now I see it is there, just the path is funny in the config repo... makes sense now
man this SPEC file is messy 😅
yes it is
there's a missing "Source8:" if you want to slot in there 😉
oh
whoops I made a
Source23
yeah i'll just keep it as is
source 8 is likely best reserved for another justfileno worries 🙂
suggestion on doing these... just run a local container build from your
ublue-os/config locally checked out branch
podman build -f Containerfile -t config:39
you'll see that currently this RPM fails to buildthanks
looks like the rpm manages to the build
yeah, i just approved, lookin' good! thank you!
should we be careful because of the conflicting target in bluefin?
yeah conflicting targets give just an error
i'll make a PR to bluefin to fix this
@j0rge just brought up another issue in #💾ublue-dev
https://github.com/ublue-os/bluefin/pull/988/files#diff-5fcdf9b4580789697d834d1456a22bcfaa236d668fc180cad4775afc36ed5914
i'm not sure if we want the config RPM manipulating the systemd/user.conf though
that's fine for our opininated images to do, but i dunno about having the rpm do it
oh sorry missed this thread
https://github.com/ublue-os/bluefin/blob/main/just/bluefin-apps.just
we could make it a responsibility of downstream to modify limits if you want blue?
do you have any suggestions how best to implement this?
i dunno
this has an alias so it's
ujust brew, will the alias still work?
or should I add the alias to config?
(line 13)i'll add alias to the 00-default.just to match bluefin
ack
almost forgot about that
my vote is probably that config repo and just RPM does it's part by providing the installer, but if an image really wants to use it, they need to set limits
we could just say "if you're using a custom image you need this brew config" so we don't have to special case it?
otherwise, i think we risk clobbering what other things bluefin/bazzite/etc may want to do
agree 100%
and if people with custom images are hitting this we just tell them how to fix
i don't think ALL uses of brew install will hit the bug, only bigger packages ... i hope
plus I bet bazzite already has stuff like this, this is just like when you install texlive it runs out of handles, you know, defaults that the distro should have fixed 10 years ago. 😄
ok, i really gotta go... family
yeah it's like texlive, most people won't notice
maybe the ulimit file is
curled down from github if it doesn't already exist?
sounds a bit hacky thoughStatus like this would be great: "No-file limit fix: Enabled"
It would check if number is equal or greater then something
I modify both system.conf & user.conf.
Not sure if only user.conf is needed.
@j0rge the version merged into
config doesn't have the ujust brew alias
should I create another PR or is it good just to leave the alias up to bluefin/bazzite?yes please
link me and I'll ack it.
bazzite has them all cranked up
thanks for the parachute save!
We got a TON of stuff done today
https://github.com/ublue-os/config/pull/236
@j0rge ^
thoughts on including the ulimit file in the udev rules?
we went with keeping main stock, bazzite and bluefin set their own limits
It is an interesting idea.
But yeah, I wonder about that crossing the line for changes in main.
Yeah
What would be the downsides to including it in main? Is there potential software incompatibility or a possibility for fedora to change something upstream to break it?
I was also thinking about trying to detect the ulimit in the script and provide instructions to get it configured
Well, even with only ublue main, bazzite and bluefin in question, we have 3 distinct configurations.
Bazzite adjust limits to the max because gamers.
Bluefin has some reasonable level
Main is stock.
The issue is how all the ways of setting ulimit interact.
It took some effort to discover that limits.conf doesn’t work as expected in DE environments. Instead systemd configs had to be modified.
I’m not sure how a udev rule would interact with either
thought it would moreso fit into the udev rules category of tweaks, but I understand now why keeping the stock config makes sense for main