H
HASS.Agentโ€ข9mo ago
Bucky

HASS.Agent Client bugs out if you leave Satellite service open when closing the main window

Holy bug reports ๐Ÿ˜‚ Replication: - Open HASS.Agent - Open Satellite Service config - Close HASS.Agent Expected: - Both windows closes; or - Satellite window is unaffected Actual: - Satellite window remains but is blanked out
No description
Solution:
GitHub
Fix: close all subwindows when main one is closed by amadeo-alex ยท ...
This simple PR fixes the issue where configuration subwindows would stay open (in some cases in broken state) after the main windows was closed by the user. Thanks to @KohGeek for reporting :)
Jump to solution
4 Replies
Amadeo
Amadeoโ€ข9mo ago
holy hell xD this should get some kind of award ๐Ÿ˜„
Bucky
BuckyOPโ€ข9mo ago
HAHAHAH all in a good day's work to try to break Satellite I swear I normally don't get to be the first reporter for these kind of things HAHAHAHH
Amadeo
Amadeoโ€ข9mo ago
ok, after realizing that "close hass.agent" meant window and not whole client - reproduced on 2.1.0 dev branch ๐Ÿ˜„ ok, POC fix ready closes all windows when the main one is hidden will be part of 2.1.0-beta2 thanks for the report ๐Ÿ˜„
Solution
Amadeo
Amadeoโ€ข8mo ago
GitHub
Fix: close all subwindows when main one is closed by amadeo-alex ยท ...
This simple PR fixes the issue where configuration subwindows would stay open (in some cases in broken state) after the main windows was closed by the user. Thanks to @KohGeek for reporting :)
Want results from more Discord servers?
Add your server