C#•8mo ago

How can i simplify multiple conditions?

LocaleFormatter.cs

4 Replies

$paste

MODiX•8mo ago

If your code is too long, you can post to https://paste.mod.gg/ and copy the link into chat for others to see your shared code!

Ne1gh•8mo ago

nice cat :)

oke•8mo ago

personally, i think the if statements were perfectly fine but there were a few other places that could use optimizations or just general replacements i replaced .Substring() with ranges, replaced the string with a StringBuilder in GetFormattingCode(), and a few small things

public LocaleSymbol HandleFormatting(string formattingCode, LocaleSymbol prevSymbol)
{
    if (formattingCode == "#")
        prevSymbol.Wrap = true;
    else if (formattingCode[0] == '%')
        prevSymbol.TextSpeed = int.Parse(formattingCode[1..]);
    else if (formattingCode.Contains('~'))
    {
        var perLetter = formattingCode.Contains('@');
        var parsedShakingData = formattingCode[(1 + perLetter.ToInt())..].Split(", ");
        var shaking = new Shaking((Vector2.One * int.Parse(parsedShakingData[0])).ToVector3());

        shaking.IsLerped = bool.Parse(parsedShakingData[1]);

        prevSymbol.Shaking = shaking;
        prevSymbol.ShakingWholeFragment = !perLetter;
    }
    else if (formattingCode[0] == '&')
    {
        if (formattingCode.Contains("New"))
        {
            string colorValuesInString = formattingCode[5..].Replace(')', '\0');

            string[] colorValues = colorValuesInString.Split(", ");

            prevSymbol.Color = new Color(
                Convert.ToByte(colorValues[0]),
                Convert.ToByte(colorValues[1]),
                Convert.ToByte(colorValues[2])) * Convert.ToSingle(colorValues[3]);
        }
        else
            prevSymbol.Color = ColorExtensions.NameToColor(formattingCode[1..]);
    }

    return prevSymbol;
}

public string GetFormattingCode(string text)
{
    // Use a string builder to reduce memory usage
    StringBuilder sb = new();

    foreach (var c in text)
    {
        if (c == '>')
            break;

        formattingCode.Append(c);
    }

    return formattingCode.ToString();
}

public LocaleSymbol HandleFormatting(string formattingCode, LocaleSymbol prevSymbol)
{
    if (formattingCode == "#")
        prevSymbol.Wrap = true;
    else if (formattingCode[0] == '%')
        prevSymbol.TextSpeed = int.Parse(formattingCode[1..]);
    else if (formattingCode.Contains('~'))
    {
        var perLetter = formattingCode.Contains('@');
        var parsedShakingData = formattingCode[(1 + perLetter.ToInt())..].Split(", ");
        var shaking = new Shaking((Vector2.One * int.Parse(parsedShakingData[0])).ToVector3());

        shaking.IsLerped = bool.Parse(parsedShakingData[1]);

        prevSymbol.Shaking = shaking;
        prevSymbol.ShakingWholeFragment = !perLetter;
    }
    else if (formattingCode[0] == '&')
    {
        if (formattingCode.Contains("New"))
        {
            string colorValuesInString = formattingCode[5..].Replace(')', '\0');

            string[] colorValues = colorValuesInString.Split(", ");

            prevSymbol.Color = new Color(
                Convert.ToByte(colorValues[0]),
                Convert.ToByte(colorValues[1]),
                Convert.ToByte(colorValues[2])) * Convert.ToSingle(colorValues[3]);
        }
        else
            prevSymbol.Color = ColorExtensions.NameToColor(formattingCode[1..]);
    }

    return prevSymbol;
}

public string GetFormattingCode(string text)
{
    // Use a string builder to reduce memory usage
    StringBuilder sb = new();

    foreach (var c in text)
    {
        if (c == '>')
            break;

        formattingCode.Append(c);
    }

    return formattingCode.ToString();
}

Gaming

Programming

How can i simplify multiple conditions?