Upgraded from Twill 2.13 to 3.2, frontend error when saving a module that uses 'editInModal' => true
I upgraded from Twill 2.13 to 3.2. When saving a module that is created/edited via a modal (using $indexOptions
'editInModal' => true the changes save to the DB, but afterwards an error occurs which locks up the frontend so the screen has to be refreshed.
Steps to reproduce for my install are as follows:
1. Go to module (Projecttag) edit screen, add or edit a record, modal pops up.
2. Click "create/update". Screen overlays grey, yellow "success" bar pops up (changes do save to DB), but the overlay doesn't disappear due to an error, so the frontend locks up. The following errors are present:
In browser console:
TWILL - [CONTENT]: Request failed with status code 500
TWILL - [DATATABLE]: Get request error.
In Network XHR tab:
500
Get request: https://mysite.test/my-admin-panel/designpages/projecttags?sortKey=&sortDir=asc&page=1&offset=21&columns[]=draggable&columns[]=bulk&columns[]=published&columns[]=title&filter[status]=all
Response: json_decode(): Argument #1 ($json) must be of type string, array given
File: /Users/me/Sites/mysite/vendor/area17/twill/src/Http/Controllers/Admin/ModuleController.php
Line: 2135
Everything works correctly if I do not use editInModal - I'll have to fall back on that if I can't resolve the issue 😆 Any ideas?
Hope you can help, thank you very much as always.6 Replies
This is the culprit: https://github.com/area17/twill/issues/2518
GitHub
Axios breaks datatable filters · Issue #2518 · area17/twill
Description The Axios update to v0.28.0 had some breaking changes in parameter serialization. Objects and Arrays are now provided in a bracket style instead of an object style: New: &filter[sta...
we are going to release 3.2.1 asap this week, in the meantime going back to 3.1.0 would work
OK cool, thanks! Happy to wait a little longer, it's not urgent. Thanks again! 😃
@ifox any more news re 3.2.1?
releasing this week @sebastianlenton
Thanks for the update, appreciated!
Hey @ifox sorry to keep asking, any more news re 3.2.1? I think we'll have to roll back to 3.1 if it doesn't come this week. No problem if it's delayed- thank you.
Just spotted it's been released now- I've been refreshing the Github releases page for weeks 😆 Thank you very much!
sorry for the delay @sebastianlenton