a question about bazzite isogenerator EXTRA_BOOT_PARAMS
@Noel you asked a question about bazzite not picking up EXTRA_BOOT_PARAMS in isogenerator
3 Replies
so I'm looking at it
I think i found the answer...
In isogenerator's
action.yml https://github.com/ublue-os/isogenerator/blob/e36da208a85c42dff07a95aafd80c6decfa52be8/action.yml#L110 there's inputs which DO get passed to the Makefile. so...
In the problematic build I see this:
first, trying to determine EXTRA_BOOT_PARAMS https://github.com/ublue-os/bazzite/actions/runs/8040573797/job/21958829200#step:3:2
second, failing to use that as an input to the action https://github.com/ublue-os/bazzite/actions/runs/8040573797/job/21958829200#step:4:3
so, maybe that build ran before this was added to the workflow?
https://github.com/ublue-os/bazzite/blob/main/.github/workflows/build_iso.yml#L47
or... this just doesn't add anything to env. or both
https://github.com/ublue-os/bazzite/blob/main/.github/workflows/build_iso.yml#L34I think this should fix it
https://github.com/ublue-os/bazzite/pull/813
GitHub
chore(ci): add EXTRA_BOOT_ARGS to env for ISO build by bsherman · P...
I think this may fix the mystery of the missing EXTRA_BOOT_ARGS in the ISO build.
your fix worked! Thanks @bsherman! you're the bomb!