ublue-os github action retries
I am trying to improve the reliability of builds - I see these fail a lot. There is a way to retry the build action, and I have a PR for it here. https://github.com/ublue-os/main/pull/503
It relies on a workaround though to format the input for the next stage, particularly the labels for the container image.
GitHub
feat: leverage retry-action to increase reliability of builds. by d...
This is a proposed implementation of #502. It needs to run the GitHub action to be tested, but should improve reliability without manual build re-triggers.
6 Replies
Wanna chat here or in github?
because you filed an issue and immediately filed a PR, too... it'
I'm not sure which is best to give feedback 🙂
I've added requests to the PR.
https://github.com/ublue-os/main/pull/503#pullrequestreview-1887362761
GitHub
feat: leverage retry-action to increase reliability of builds. by d...
This is a proposed implementation of #502. It needs to run the GitHub action to be tested, but should improve reliability without manual build re-triggers.
I wonder if the error that occurred during that PR run would have been mitigated by a retry on the build action.
https://github.com/ublue-os/main/actions/runs/7963485625/job/21739276664
GitHub
feat: leverage retry-action to increase reliability of builds. · ub...
OCI base images of Fedora with batteries included. Contribute to ublue-os/main development by creating an account on GitHub.
Seems like a random failure on just a couple of jobs unrelated to upstream dependencies.
I am fine with not doing a retry on the build action for now and maybe adding that later.
I have opened https://github.com/ublue-os/main/pull/506 and feel it might be the better way to do it.
GitHub
feat: leverage retry-action to increase reliability of builds on al...
This is a different variant of the other PR (#503) but with the build step having a retry on it as well.
@bsherman - I think this might be the better version of the other PR, as it had a sporadic b...
What's the worst case scenario? We wait 10 more minutes for it to fail if it's a dependency issue?