Zod•2y ago

Alex - Hi there, I am trying to validate a numb...

Hi there, I am trying to validate a number using zod. The number is first received as a string and could possibly be anything because it comes from a user input.

z.coerce.number().int("Invalid Value").positive("Must be a positive number").safeParse(maxQuantity);

z.coerce.number().int("Invalid Value").positive("Must be a positive number").safeParse(maxQuantity);

`
This is my current schema, where maxQuantity is the said string. Now when I pass "d" as maxQuantity, I receive the error "Must be a positive number". How do I give an error that this is not even a number?

Solution

z
            .string()
            .regex(/^[-]?\d*\.?\d+$/, "Must be a number")
            .pipe(z.coerce.number().int("Must be an integer").positive("Must be a positive number"))
            .safeParse(maxQuantity);

z
            .string()
            .regex(/^[-]?\d*\.?\d+$/, "Must be a number")
            .pipe(z.coerce.number().int("Must be an integer").positive("Must be a positive number"))
            .safeParse(maxQuantity);

Jump to solution

Scott Trinh•2/7/24, 9:19 PM

You have to split the string parsing and the number refinement into two steps.

Scott Trinh•2/7/24, 9:19 PM

Luckily with pipe, this is a little more elegant than the preprocess solution we had before.

Scott Trinh•2/7/24, 9:31 PM

Something like this:

https://codesandbox.io/p/devbox/pedantic-breeze-v4cc7w

AlexOP•2/7/24, 9:34 PM

cannot open the sandbox. what is that regex doing exactly? because I would expect my inital schema to give me an error because coerce should fail. also, because I get "Must be a positive number" as error, that means the int check was passed, which again means, coerce returned a number. that should not be the case, because coerce just uses the Number() constructor, which would give NaN when passing "d"

Scott Trinh•2/7/24, 9:35 PM

Coerce just literally calls which doesn't fail, just returns

AlexOP•2/7/24, 9:35 PM

correct, so how is the int check passing?

Scott Trinh•2/7/24, 9:35 PM

That regex just ensures that the string is an integer-like thing

AAlex correct, so how is the int check passing?

Scott Trinh•2/7/24, 9:39 PM

I'm not sure, to be honest.

AlexOP•2/7/24, 9:39 PM

I am also very confused, I will investigate further, just wanted to check I am not doing something obvious wrong

Scott Trinh•2/7/24, 9:42 PM

fwiw, when I try to run it in the codesandbox, I do get the error for with as the input

Scott Trinh•2/7/24, 9:44 PM

oh, actually I get expected number received nan as the error.

Scott Trinh•2/7/24, 9:44 PM

for some reason I thought

number

number

accepted but maybe that's changed since the last time I looked at it

AlexOP•2/7/24, 9:55 PM

maybe I am just reading one error for some reason, i will check

AlexOP•2/7/24, 9:57 PM

nope, but still cannot access the code sandbox

Scott Trinh•2/7/24, 9:59 PM

Ahh, here ya go: https://codesandbox.io/p/devbox/pedantic-breeze-v4cc7w?file=%2Fsrc%2Findex.ts%3A11%2C40

Scott Trinh•2/7/24, 9:59 PM

Wasn't up to speed on all the latest codesandbox changes to sharing and permissions.

AlexOP•2/7/24, 9:59 PM

yes, works, thanks

AlexOP•2/7/24, 10:12 PM

now using this, which works as I originally intended:

Scott Trinh•2/7/24, 10:13 PM

Might want to tweak the regex to allow negative numbers so that you don't reject with "Must be a number", but yeah that seems about right!

AlexOP•2/7/24, 10:13 PM

yes, true, thanks!

Solution

Alex•2/7/24, 10:15 PM

z
            .string()
            .regex(/^[-]?\d*\.?\d+$/, "Must be a number")
            .pipe(z.coerce.number().int("Must be an integer").positive("Must be a positive number"))
            .safeParse(maxQuantity);

z
            .string()
            .regex(/^[-]?\d*\.?\d+$/, "Must be a number")
            .pipe(z.coerce.number().int("Must be an integer").positive("Must be a positive number"))
            .safeParse(maxQuantity);

AlexOP•2/7/24, 10:16 PM

Thanks again, very helpfull!