SFUI 1 - SfModal have 2 close buttons on mobile
I'm using storefront-ui 0.13.3 - SFUI 1 . Checked everything and i think there's a bug in this package. on Mobile version it shows 2 x buttons


10 Replies

extra code? in SfModal component

hey, thanks for letting us know! Let me investigate further and come back to you 🙂
Nice to e-meet you again 😄
hmmm...this is strange, I opened v0.13.3 as you said and for me this block of code is not commented out

ah, I suspect you commented it out not to render it 😄
so, on further investigation, sf-modal__bar - is used for mobile only, and SfButton below is used for desktop only.
you can see the class names 🙂

yes. so the clases are not applying or the browser does not know how to compile when those classes are applied
oh damn, I just saw two buttons there 🙈
can you try to update library to 0.13.6 and check it again?
ofcourse
Same!
@skirianov any updates?