C#•3y ago

❔ Question about getter property of list

so, i have some class containg property of type:

List<string>

List<string>

List<string>

List<string> , how can i thread-safe return this list as some kind of snapshot of current state of list?
right now i'm doing it in followoing way but i'm not sure if it okey

private readonly object _lock = new();
private readonly List<string> _strings = [];
public IReadOnlyList<string> Strings {
  get {
    lock(_lock)
      return [.._strings];
  }
}

private readonly object _lock = new();
private readonly List<string> _strings = [];
public IReadOnlyList<string> Strings {
  get {
    lock(_lock)
      return [.._strings];
  }
}

private readonly object _lock = new();
private readonly List<string> _strings = [];
public IReadOnlyList<string> Strings {
  get {
    lock(_lock)
      return [.._strings];
  }
}

private readonly object _lock = new();
private readonly List<string> _strings = [];
public IReadOnlyList<string> Strings {
  get {
    lock(_lock)
      return [.._strings];
  }
}

Jimmacle•11/1/23, 2:31 PM

a snapshot would be a copy

Jimmacle•11/1/23, 2:31 PM

so looks fine at first glance

Jimmacle•11/1/23, 2:32 PM

i dunno if i'd make it a property, because copying a list might be expensive in terms of what a property getter should do

CrosRoad95OP•11/1/23, 2:32 PM

do you have any other idea?

CrosRoad95OP•11/1/23, 2:32 PM

in theory, i need it for single iteration

Jimmacle•11/1/23, 2:32 PM

make it a method instead

CrosRoad95OP•11/1/23, 2:32 PM

in few places i used

yield return

yield return

inside lock

Accord•11/2/23, 2:49 PM

Was this issue resolved? If so, run

/close

/close

otherwise I will mark this as stale and this post will be archived until there is new activity.