C#•3y ago

❔ EF Migration successful but nothing changes

I can see that the commands resulted OK, the migration has the new columns and the database has the new migration in it's history

Yet the new columns in the model have not been added to the database

I have made migrations many times in this project without problems, attaching relevant pictures and migration (Newest migration is "addSuccessIncrement14" and a new column is "waitDescription")

I have tried Clean/Rebuild, and checked GPTs suggestions

20231016103950_addSuccessIncrement14.Designer.cs5.93KB

Pobiega•10/16/23, 10:53 AM

You attached the wrong file

Pobiega•10/16/23, 10:53 AM

can you show the generated migration file, not the one containing the snapshot for that state

OkOkOP•10/16/23, 11:49 AM

It contains empty Up/down-methods so EF didn't detect any changes to generate the migration

Pobiega•10/16/23, 11:50 AM

right

Pobiega•10/16/23, 11:50 AM

thats why your migration does nothing

Pobiega•10/16/23, 11:50 AM

as to WHY ef didnt detect any changes, I cant tell

Pobiega•10/16/23, 11:50 AM

try to remove that migration and check the snapshot

Pobiega•10/16/23, 11:50 AM

does it still contain the "new" column?

Pobiega•10/16/23, 11:50 AM

then its not new

OkOkOP•10/16/23, 11:55 AM

@Pobiega Yes the snapchat still contains the "new" column after deletion

Altough there was no migrations that contain the addition of the new column

OkOkOP•10/16/23, 11:56 AM

Before this, I tried to temporarily change the connection string to another local db, and that db has the new column

OkOkOP•10/16/23, 11:57 AM

But not one migration file with up/down contains the name of the column

OkOkOP•10/16/23, 12:03 PM

I added another property called testString and migrated, now that column appears in migration/db but not the other new properties

Pobiega•10/16/23, 12:07 PM

curious.

OkOkOP•10/16/23, 12:08 PM

Yes right

OkOkOP•10/16/23, 12:08 PM

Recognizing new properties but not old ones

Pobiega•10/16/23, 12:08 PM

the snapshot isnt derived from the actual database, its just a... continous evolution of your model

OkOkOP•10/16/23, 12:08 PM

Everything is the same, public and whatnot

OkOkOP•10/16/23, 12:10 PM

It has to be relating to that temporary copy of the db, that contained all the new columsn

OkOkOP•10/16/23, 12:10 PM

Because those will not be added to the original db

OkOkOP•10/16/23, 12:11 PM

I think this is a case of software not working as intended, but I should not cast doubt so soon on something so vigorously tested

OkOkOP•10/16/23, 12:11 PM

ApplicationDbContextModelSnapshot.cs5.94KB

OkOkOP•10/16/23, 12:12 PM

20231016120718_addSuccessIncrement3.Designer.cs6.04KB

OkOkOP•10/16/23, 12:13 PM

I should learn to read these, but maybe this will lead to a report because I can't see any suggestions for making EF recognize these model changes that I have not yet tried

OOkOk I think this is a case of software not working as intended, but I should not cas...

Pobiega•10/16/23, 12:13 PM

I frankly doubt it, EF is used by millions

Pobiega•10/16/23, 12:14 PM

it might seem weird, but its almost always user error somehow

Pobiega•10/16/23, 12:14 PM

have you ever added then removed migrations before, and not via the command?

Pobiega•10/16/23, 12:14 PM

that could easily "corrupt" your snapshot

fasadin•10/16/23, 12:29 PM

if you deleted manually already executed migration then migration table is corrupted. That's probably what's going on, and now it cannot find your changes

fasadin•10/16/23, 12:29 PM

my question would be. Is it possible for you to reset your migration?

Pobiega•10/16/23, 12:29 PM

exactly

fasadin•10/16/23, 12:29 PM

the easiest would be to reset whole history "start" over with one big migration

OkOkOP•10/16/23, 12:29 PM

Thank you I think you are right

Someone(absolutely not me) has deleted without proper command

Pobiega•10/16/23, 12:30 PM

you could also fix your snapshot manually, via "snapshot surgery"

fasadin•10/16/23, 12:30 PM

if that's production code, then you need to manipulate changes in db manually

OkOkOP•10/16/23, 12:30 PM

I'm trying to repair as we speak

Pobiega•10/16/23, 12:30 PM

its annoying, but not impossible, to manually edit the snapshot

Pobiega•10/16/23, 12:30 PM

alterantively, make a blank DB, run the latest migration, take that snapshot, go back to your normal code, paste snapshot

OkOkOP•10/16/23, 12:30 PM

It's in development

Pobiega•10/16/23, 12:30 PM

and pray to god

OkOkOP•10/16/23, 12:31 PM

So I think easiest solution is to start over like you say

OkOkOP•10/16/23, 12:31 PM

Sorry god is not on my side

fasadin•10/16/23, 12:31 PM

okok, is this running code on production?

fasadin•10/16/23, 12:31 PM

I mean if you have any migration on production

OkOkOP•10/16/23, 12:31 PM

No there is nothing in prod

fasadin•10/16/23, 12:31 PM

then it's far better to repair

fasadin•10/16/23, 12:31 PM

ah, delete all and start over

Pobiega•10/16/23, 12:31 PM

if you are fine with resetting your databases, you could just delete your DBs and all migrations

Pobiega•10/16/23, 12:31 PM

and generate a brand new "initial" migration

fasadin•10/16/23, 12:32 PM

excatly