❔ Timer - C#

TeBeCo

T

TeBeCo•10/10/23, 11:22 AM

share your existing code, it's a bit blurry

RXDCODX

R

RXDCODXOP•10/10/23, 11:26 AM

TeBeCo

T

TeBeCo•10/10/23, 11:30 AM

I would honestly remove all the singleton part

TeBeCo

T

TeBeCo•10/10/23, 11:30 AM

and let the just store the instance

TeBeCo

T

TeBeCo•10/10/23, 11:30 AM

that would remove code complexity

TeBeCo

T

TeBeCo•10/10/23, 11:31 AM

why not just use the class directly exactly ?

TeBeCo

T

TeBeCo•10/10/23, 11:31 AM

timer ??= new();
timer.Stop();
timer.Interval = x;
timer.Start();

TeBeCo

T

TeBeCo•10/10/23, 11:32 AM

=> use

TeBeCo

T

TeBeCo•10/10/23, 11:32 AM

don't use if you can

TeBeCo

T

TeBeCo•10/10/23, 11:32 AM

TeBeCo

T

TeBeCo•10/10/23, 11:32 AM

ok maybe you can't it's horrible

TeBeCo

T

TeBeCo•10/10/23, 11:33 AM

bad class

TeBeCo

T

TeBeCo•10/10/23, 11:33 AM

to be clear I don't understand what your code it supposed to do

TeBeCo

T

TeBeCo•10/10/23, 11:33 AM

you're creating a timer that stop ticking ?

TeBeCo

T

TeBeCo•10/10/23, 11:34 AM

and you can add time before it ticks ?

RXDCODX

R

RXDCODXOP•10/10/23, 11:34 AM

Yes, I'm trying to write an event that triggers when the time on the timer changes

TeBeCo

T

TeBeCo•10/10/23, 11:35 AM

which time ?

TeBeCo

T

TeBeCo•10/10/23, 11:35 AM

the actual time ?

TeBeCo

T

TeBeCo•10/10/23, 11:35 AM

or the timer time

RXDCODX

R

RXDCODXOP•10/10/23, 11:35 AM

time remaining until the end of the timer

TeBeCo

T

TeBeCo•10/10/23, 11:38 AM

well there's an issue with that

TeBeCo

T

TeBeCo•10/10/23, 11:38 AM

time never stops

TeBeCo

T

TeBeCo•10/10/23, 11:38 AM

so the time remaining for ever change

TeBeCo

T

TeBeCo•10/10/23, 11:38 AM

you're doing a countdown ?

TeBeCo

T

TeBeCo•10/10/23, 11:38 AM

if so you need an additional timer

TeBeCo

T

TeBeCo•10/10/23, 11:38 AM

which have it own interval at which you want to publish the remaing

TeBeCo

T

TeBeCo•10/10/23, 11:39 AM

1 real timer + api to possibly change the ultimate / end date
1 redundant timer to update the remaining

Accord

A

Accord•10/11/23, 12:09 PM

Was this issue resolved? If so, run

/close

/close

otherwise I will mark this as stale and this post will be archived until there is new activity.

class Program
{
    static void Main()
    {
        SpecialTimer specialTimer = SpecialTimer.Instance;

        specialTimer.TimeLeftChanged += TimeLeftChangedHandler;

        specialTimer.AddTime(10);

        Console.ReadLine();
    }

    private static void TimeLeftChangedHandler(int secondsLeft)
    {
        Console.WriteLine($"Time left: {secondsLeft} seconds");
    }

    public class SpecialTimer : System.Timers.Timer
    {
        private static SpecialTimer instance;
        private static readonly object lockObject = new object();

        public delegate void TimeLeftChangedHandler(int secondsLeft);

        public event TimeLeftChangedHandler? TimeLeftChanged;

        private SpecialTimer() : base()
        {
            Elapsed += TimerElapsed;
        }

        private void TimerElapsed(object sender, ElapsedEventArgs e)
        {
            Stop(); 
        }

        public void AddTime(int seconds)
        {
            if (Enabled && Interval > 0)
            {
                Stop(); 

                double newInterval = Interval + seconds * 1000;
                Interval = newInterval > 0 ? newInterval : 0;

                Start(); 
            }
            else
            {
                instance = new SpecialTimer();
                instance.Interval = seconds * 1000;
                instance.Start();
            }
        }

        public static SpecialTimer Instance
        {
            get
            {
                lock (lockObject)
                {
                    return instance ?? (instance = new SpecialTimer());
                }
            }
        }
    }
}

class Program
{
    static void Main()
    {
        SpecialTimer specialTimer = SpecialTimer.Instance;

        specialTimer.TimeLeftChanged += TimeLeftChangedHandler;

        specialTimer.AddTime(10);

        Console.ReadLine();
    }

    private static void TimeLeftChangedHandler(int secondsLeft)
    {
        Console.WriteLine($"Time left: {secondsLeft} seconds");
    }

    public class SpecialTimer : System.Timers.Timer
    {
        private static SpecialTimer instance;
        private static readonly object lockObject = new object();

        public delegate void TimeLeftChangedHandler(int secondsLeft);

        public event TimeLeftChangedHandler? TimeLeftChanged;

        private SpecialTimer() : base()
        {
            Elapsed += TimerElapsed;
        }

        private void TimerElapsed(object sender, ElapsedEventArgs e)
        {
            Stop(); 
        }

        public void AddTime(int seconds)
        {
            if (Enabled && Interval > 0)
            {
                Stop(); 

                double newInterval = Interval + seconds * 1000;
                Interval = newInterval > 0 ? newInterval : 0;

                Start(); 
            }
            else
            {
                instance = new SpecialTimer();
                instance.Interval = seconds * 1000;
                instance.Start();
            }
        }

        public static SpecialTimer Instance
        {
            get
            {
                lock (lockObject)
                {
                    return instance ?? (instance = new SpecialTimer());
                }
            }
        }
    }
}