C#•3y ago

✅ ✅ Issues With Input Validation

public static string? VerifyEmptyOrChanged(string? oldEntry, string newEntry)
{
    if (String.IsNullOrEmpty(newEntry) || newEntry == oldEntry)
    {
        return oldEntry;
    }
    else
    {
        return newEntry;
    }
}

public static string? VerifyEmptyOrChanged(string? oldEntry, string newEntry)
{
    if (String.IsNullOrEmpty(newEntry) || newEntry == oldEntry)
    {
        return oldEntry;
    }
    else
    {
        return newEntry;
    }
}

I'm asking the user for information when they select to update an entry within the database. Their instruction is to just press enter and leave the entry blank if they want to keep the information the same, however, I also need this function to check a date format and a time format (two separate checks) and I can't figure it out. To clarify, The first entry is asking them for an adjusted date, or to leave it empty. When they put in something, it needs to check if that entry is empty or not and whether it matches

MM/dd/yyyy

MM/dd/yyyy

format. Then it asks them for the updated start time, or to leave it empty. That needs to check if the entry is empty and whether it matches

HH:MM

HH:MM

format and same for the third check. Thanks

MekOP•10/4/23, 1:36 AM

so like

When it prompts and the user enters their information, or leaves it blank and the validation function is ran, it needs to check

Is the string empty
If not empty, does it match
If not empty, does it match
```
HH:MM
```
```
HH:MM
```
and return the string when conditions are met

Pobiega•10/4/23, 5:32 AM

Sounds like you want three different methods instead of just one

Pobiega•10/4/23, 5:32 AM

Since you call them distinctly anyways

MekOP•10/4/23, 6:48 AM

Yes but no. If it’s possible to have 3 checks in 1 call then id rather go that route tbh. I’m already having to write 100+ lines per file and I’ve only gotten 2/8 menu options completed besides this minor set back. I’d rather not have to write 15 more lines if I don’t have to

Pobiega•10/4/23, 6:53 AM

That's the wrong mindset tbh

Pobiega•10/4/23, 6:54 AM

Methods should be specific rather than broad

Pobiega•10/4/23, 6:54 AM

You certainly can do this with one method, but it'll be harder to reason about

Pobiega•10/4/23, 6:55 AM

Like, it will accept a date when you really expected a time

Pobiega•10/4/23, 6:55 AM

Or opposite

MekOP•10/4/23, 6:58 AM

Tbh you’re right. I just wanted an easier way of it but frankly 15 lines in the same function or 15 lines between 3 functions are still 15 lines

Pobiega•10/4/23, 6:59 AM

yup

Pobiega•10/4/23, 6:59 AM

And most importantly, you prevent a time from being saved in the date field (or crashing because you expected the value to be parsable when it wasnt)

MekOP•10/4/23, 6:59 AM

True. Thank you

PPobiega yup

MekOP•10/4/23, 4:37 PM

ok so I'm having a problem with getting the order of calls right

MekOP•10/4/23, 4:38 PM

this is the primary function. When it asks the user for the newDate, it checks to see if the input is empty or not.

MekOP•10/4/23, 4:39 PM

these are the validation functions that I created for checking if the string is empty, or not. Check if it's the correct date format and time format. So since the first question deals with the date, how would I do the call order to check if the string is empty or not, and if not then check it's date format?

Pobiega•10/4/23, 4:44 PM

i uh... what

Pobiega•10/4/23, 4:45 PM

those methods are... what?

Pobiega•10/4/23, 4:45 PM

looped AND recursive AND returns when it never returns null?

Pobiega•10/4/23, 4:45 PM

this is confusing

MekOP•10/4/23, 4:46 PM

ok I'll fix it

Pobiega•10/4/23, 4:46 PM

your null annotations are all wrong in general

Pobiega•10/4/23, 4:46 PM

public static string? VerifyEmptyOrChanged(string? oldEntry, string newEntry)
{
    if (String.IsNullOrEmpty(newEntry) || newEntry == oldEntry)
    {
        return oldEntry;
    }
    else
    {
        return newEntry;
    }
}

public static string? VerifyEmptyOrChanged(string? oldEntry, string newEntry)
{
    if (String.IsNullOrEmpty(newEntry) || newEntry == oldEntry)
    {
        return oldEntry;
    }
    else
    {
        return newEntry;
    }
}

Pobiega•10/4/23, 4:46 PM

newEntry is flagged as never being null, but you check it for null

Pobiega•10/4/23, 4:46 PM

so I suggest you mark it as

MekOP•10/4/23, 4:47 PM

yep. I already fixed that

MekOP•10/4/23, 4:47 PM

the part that is

Pobiega•10/4/23, 4:48 PM

right.

Pobiega•10/4/23, 4:48 PM

I'm trying to wrap my head around your original issue now.

Pobiega•10/4/23, 4:48 PM

Ah okay I see it.

MekOP•10/4/23, 4:48 PM

so it checks if the newEntry is empty or if the new entry matches the current entry. If it is empty or does match, it returns the current entry. Otherwise, it returns the new entry

Pobiega•10/4/23, 4:48 PM

you need the "allow null/empty to keep same value", while still validating dates/times

Pobiega•10/4/23, 4:49 PM

my gut instinct is to use higher order functions, but that might be... hard?

Pobiega•10/4/23, 4:49 PM

its the idea of passing functions as parameters to other functions

MekOP•10/4/23, 4:49 PM

I haven't learned that yet

Pobiega•10/4/23, 4:50 PM

Would you be okay with learning it now, or prefer a simpler approach?

Pobiega•10/4/23, 4:53 PM

also, just so I can see all the types involved here can you show me the class?

MekOP•10/4/23, 4:53 PM

and I'm not entirely sure on how to go about that. There are 3 entry inputs. newDate, newStartTime, and newEndTime.

all 3 check for if the newEntry is empty or matches the oldEntry so that if the newEntry is empty or matches the oldEntry, it can keep the same value that's currently recorded in the database.
newDate needs to check against the format to follow the requirements
newStartTime and newEndTime needs to check against the
```
HH:MM
```
```
HH:MM
```
format to follow the same requirements.

The 3 are checked against the String.Format()'s in the event the user wants to change the information and doesn't leave the newEntry blank

PPobiega also, just so I can see all the types involved here can you show me the `CodeSes...

MekOP•10/4/23, 4:54 PM

they're all strings except the Id because of the Tip on the projects page

Pobiega•10/4/23, 4:54 PM

okay

Pobiega•10/4/23, 4:54 PM

The simplest way to do this is to have your Date/Time validations allow a blank string

Pobiega•10/4/23, 4:55 PM

ie, they allow valid times/dates or blank string

Pobiega•10/4/23, 4:55 PM

so "" is a "valid time"

Pobiega•10/4/23, 4:55 PM

and would mean keep the old time

Pobiega•10/4/23, 4:56 PM

you could then call it like

Pobiega•10/4/23, 4:56 PM

so as long as the user is trying to use a non-blank value, its validated

Pobiega•10/4/23, 4:57 PM

but if its blank, we just say "oh you wanted to keep the old value, thats fine"

Pobiega•10/4/23, 4:57 PM

that solves your "order of operations" problem

Pobiega•10/4/23, 4:57 PM

isnt valid code btw, as I'm sure you know

Pobiega•10/4/23, 4:58 PM

or actually it might be, but it doesnt do what you think it does

public static string? VerifyEmptyOrChanged(string? oldEntry, string newEntry) { if (String.IsNullOrEmpty(newEntry) || newEntry == oldEntry) { return oldEntry; } else { return newEntry; } }