NFTStorefront stable cadence tests failing
I'm working on stable cadence preview updates in NFTStorefront and am getting failure in NFTStorefront go tests - https://github.com/onflow/nft-storefront/pull/89
Anyone able to help troubleshoot? (fair warning: I'm new to go)
18 Replies
I've created a thread for your message. Please continue any relevant discussion in this thread.
You can rename this thread using
/title <new title>
If this is a technical question that others may benefit from, considering also asking it on Stackoverflow: https://stackoverflow.com/questions/ask?tags=onflow-cadenceUnknown User•14mo ago
Message Not Public
Sign In & Join Server To View
I ran that locally in both lib/go/contracts and lib/go/tests and there's no diff in go.sum, should there be?
Unknown User•14mo ago
Message Not Public
Sign In & Join Server To View
When I run
make ci locally from root, I get build failure on github.com/onflow/kitty-items/lib/go/test. Is it pulling the tests from kitty-items?Unknown User•14mo ago
Message Not Public
Sign In & Join Server To View
Thank you! Yeah a couple, esp NFTCatalog related need updates (pending updates to NFTCatalog). Best way to get your changes to my pr branch prob a pr to this base yeah? https://github.com/onflow/nft-storefront/tree/stable-cadence-refactor
Unknown User•14mo ago
Message Not Public
Sign In & Join Server To View
I'm assuming this feature branch does: https://github.com/onflow/sdks/tree/feature/stable-cadence
cc: @Supun
Unknown User•14mo ago
Message Not Public
Sign In & Join Server To View
nvm just merged your branch to mine locally
I worked off of this branch's contents. https://github.com/onflow/flow-nft/tree/standard-v2
Are these repos being imported as go modules?
BTW looks like your emulator updates did it. Thank you!
Unknown User•14mo ago
Message Not Public
Sign In & Join Server To View
Ah I see. I thought the transactions had been updated when the contracts were. Alright, I'll need to sort out the dependency repos before continuing on with the NFTStorefront PR then
Weird, how is it working under the hood in emulator then?
Unknown User•14mo ago
Message Not Public
Sign In & Join Server To View
Thanks for digging into that, I should've looked at those repos first as well
Unknown User•14mo ago
Message Not Public
Sign In & Join Server To View
Will do, thanks again!
Unknown User•14mo ago
Message Not Public
Sign In & Join Server To View