adding another line

adding another line..

+ [[ 38 -ge 39 ]]
+ [[ asus == \a\s\u\s ]]
+ echo 'Installing ASUS Kernel:'
+ rpm-ostree cliwrap install-to-root /
error: Writing wrapper for "usr/bin/dnf": a path led outside of the filesystem
+ rpm-ostree install akmods mock

+ [[ 38 -ge 39 ]]
+ [[ asus == \a\s\u\s ]]
+ echo 'Installing ASUS Kernel:'
+ rpm-ostree cliwrap install-to-root /
error: Writing wrapper for "usr/bin/dnf": a path led outside of the filesystem
+ rpm-ostree install akmods mock

you can see it skips to installing akmods and mock, so i don't believe it's working

bshermanOP•9/25/23, 10:22 PM

@EyeCantCU threaded

bshermanOP•9/25/23, 10:22 PM

uh... yeah i think the problem is the symlink

bshermanOP•9/25/23, 10:23 PM

if i remove that, at least remove it before the kernel swap i get totally different errors

bshermanOP•9/25/23, 10:23 PM

EyeCantCU•9/25/23, 10:23 PM

Nooooooooooooo

EyeCantCU•9/25/23, 10:24 PM

Wait what

bshermanOP•9/25/23, 10:24 PM

this is good

EyeCantCU•9/25/23, 10:24 PM

The kernel package there is literally kernel

bshermanOP•9/25/23, 10:24 PM

progress

EyeCantCU•9/25/23, 10:25 PM

Progress indeed

bshermanOP•9/25/23, 10:25 PM

ok, i'm copying this from repo's Containerfile to see how it compares

bshermanOP•9/25/23, 10:26 PM

same excpt for the addition of "kernel-uki-virt" in akmods

EyeCantCU•9/25/23, 10:27 PM

Interesting. I had to remove uki-virt in ASUS

bshermanOP•9/25/23, 10:27 PM

the copr isn't loaded

bshermanOP•9/25/23, 10:27 PM

EyeCantCU•9/25/23, 10:27 PM

So it never even grabs the kernel

bshermanOP•9/25/23, 10:28 PM

i'll have a PR in a moment

bshermanOP•9/25/23, 10:28 PM

curios why removed teh uki-virt?

EyeCantCU•9/25/23, 10:39 PM

It depends on a version of systemd not in 38. Could probably add a version check and throw it in 39

bshermanOP•9/25/23, 10:39 PM

bshermanOP•9/25/23, 10:41 PM

yeah... this kernel replacement works better when the asus-linux copr is provided

EyeCantCU•9/25/23, 10:44 PM

Hahaha

EyeCantCU•9/25/23, 10:44 PM

I'd imagine

bshermanOP•9/25/23, 11:03 PM

so, i've got the asus kmods building

bshermanOP•9/25/23, 11:03 PM

now i'm working on surface

Kyle Gospo•9/25/23, 11:10 PM

Oh lord, I never even checked for the copr.

Kyle Gospo•9/25/23, 11:10 PM

I saw the section for them and merely assumed it was already there

Kyle Gospo•9/25/23, 11:10 PM

Good catch, thank you

bshermanOP•9/25/23, 11:10 PM

what i don't know is why the error didn't fail the build, it just moved on

Kyle Gospo•9/25/23, 11:11 PM

I'm very surprised it didn't blow up with an error. You'd think it would

Kyle Gospo•9/25/23, 11:11 PM

Yeah, I can't even layer shit half the time without something going wrong. But I could go ahead and install a kernel that doesn't exist? OK

bshermanOP•9/25/23, 11:14 PM

https://github.com/ublue-os/akmods/pull/73

GitHub

fix: add missing asus copr by bsherman · Pull Request #73 · ublue-o...

This should fix the ASUS build but Surface is still not quite right.

bshermanOP•9/25/23, 11:14 PM

note that surface is NOT working right yet

bshermanOP•9/25/23, 11:15 PM

i was getting this:

bshermanOP•9/25/23, 11:15 PM

but i need to feed my kid so you guys can fix, or i can look later

EyeCantCU•9/25/23, 11:23 PM

I'll look :). Thank you for fixing ASUS!

bshermanOP•9/25/23, 11:28 PM

Dude

bshermanOP•9/25/23, 11:28 PM

Why did. That just get merged?

Kyle Gospo•9/25/23, 11:28 PM

uhh does it not check build status??

Kyle Gospo•9/25/23, 11:28 PM

that's fine, I'll fix it

bshermanOP•9/25/23, 11:28 PM

LOL

bshermanOP•9/25/23, 11:29 PM

You approved but I said it was broke LOL

bshermanOP•9/25/23, 11:29 PM

I could have drafted I guess

Kyle Gospo•9/25/23, 11:29 PM

yeah but despite that it should fail to build and never merge, no?

bshermanOP•9/25/23, 11:29 PM

Yeah except we need to figure out why it's not failig

Kyle Gospo•9/25/23, 11:29 PM

lmao it was only queued

Kyle Gospo•9/25/23, 11:29 PM

we're good

Kyle Gospo•9/25/23, 11:29 PM

cancelled

bshermanOP•9/25/23, 11:30 PM

Con you convert to draft plz? I'm on phone waiting in line for food for kid