ThoughtSpot For Developers•2y ago

Hello I ve noticed in our embedded app

Hello, I've noticed in our embedded app the KPIs across the home page are missing the ... menu to remove them. Is this something we need to set visible actions on ?

26 Replies

bill_da_golfer•2y ago

Assuming you aren't hiding anything and the user has proper privileges, they should just show up. It would help to see the embed object for these so we can better understand what you have.

billsaysthis•2y ago

      <AppEmbed
        pageId={Page.Home}
        visibleActions={allActions}
        onRouteChange={onRouteChange}
        fullHeight
        ref={embedRef}
        className={`${rootClass}__embed`}
      />

      <AppEmbed
        pageId={Page.Home}
        visibleActions={allActions}
        onRouteChange={onRouteChange}
        fullHeight
        ref={embedRef}
        className={`${rootClass}__embed`}
      />

Visible actions:

export const ANALYTICS_VISIBLE_ACTIONS = [
  Action.AddFilter,
  Action.AddParameter,
  Action.AddToFavorites,
  Action.AnswerChartSwitcher,
  Action.ConfigureFilter,
  // NOTE: Per AO-84377 the commented out actions are being temporarily removed
  // Action.CopyLink,
  // Action.CreateMonitor,
  Action.CrossFilter,
  Action.Download,
  Action.DownloadAsCsv,
  Action.DownloadAsPdf,
  Action.DownloadAsPng,
  Action.DownloadAsXlsx,
  Action.DrillDown,
  Action.DrillExclude,
  Action.DrillInclude,
  Action.Edit,
  Action.EditDetails,
  Action.EditTitle,
  Action.Explore,
  Action.LiveboardInfo,
  Action.MakeACopy,
  Action.Pin,
  Action.Present,
  Action.Remove,
  Action.RemoveCrossFilter,
  Action.Save,
  // Action.Schedule,
  // Action.SchedulesList,
  // Action.Share,
  Action.ToggleSize,
]

export const ANALYTICS_VISIBLE_ACTIONS = [
  Action.AddFilter,
  Action.AddParameter,
  Action.AddToFavorites,
  Action.AnswerChartSwitcher,
  Action.ConfigureFilter,
  // NOTE: Per AO-84377 the commented out actions are being temporarily removed
  // Action.CopyLink,
  // Action.CreateMonitor,
  Action.CrossFilter,
  Action.Download,
  Action.DownloadAsCsv,
  Action.DownloadAsPdf,
  Action.DownloadAsPng,
  Action.DownloadAsXlsx,
  Action.DrillDown,
  Action.DrillExclude,
  Action.DrillInclude,
  Action.Edit,
  Action.EditDetails,
  Action.EditTitle,
  Action.Explore,
  Action.LiveboardInfo,
  Action.MakeACopy,
  Action.Pin,
  Action.Present,
  Action.Remove,
  Action.RemoveCrossFilter,
  Action.Save,
  // Action.Schedule,
  // Action.SchedulesList,
  // Action.Share,
  Action.ToggleSize,
]

Duessa HOP•2y ago

We are explicitly specifying the visibleActions as there are other areas of the product we do not want to expose yet . . .what would be the visible actions for this area ? i.e .we have Action.Remove visible ..

bill_da_golfer•2y ago

What happens if you don't include the visibleActions? Does it show?

billsaysthis•2y ago

🤷‍♂️ I can do that but not sure it tells us anything

bill_da_golfer•2y ago

It will tell us if the visibleActions is the issue or not. Even if Action.Remove wasn't working, there should still be a ... menu.

billsaysthis•2y ago

kk one sec If I don't pass the visibleActions prop, I see the Delete action while in edit mode.

bill_da_golfer•2y ago

One thing I don't understand with your example, you have allActions in the visibleActions setting, but the list is named ANALYTICS_VISIBLE_ACTIONS.

Duessa HOP•2y ago

@Bill can you check the home page KPIs, do you see a remove menu on those? i.e. add one to your home page

billsaysthis•2y ago

How do I add a KPI to my home page?

billsaysthis•2y ago

kk Duessa explained this but I am not seeing any menu on the home page after adding the KPI, per the attached.

bill_da_golfer•2y ago

Yes, I do. I'm on 9.5, so it's possible there is a problem in 9.4, but I'm not aware of any.

Duessa HOP•2y ago

I see it in the thoughtspot app directly but not in our embedded app

bill_da_golfer•2y ago

Oh, OK, let me double check when embedding.

bill_da_golfer•2y ago

Playground has it as well. Can you see them in the playground if you just do the full app embed?

billsaysthis•2y ago

Not sure what you mean but we can't ship the playground in our app.

bill_da_golfer•2y ago

I know that. I'm trying to debug. If it works in the playground and not your code, then it's something in how you are embedding.

billsaysthis•2y ago

I posted our code for embedding above

bill_da_golfer•2y ago

Can you also post the definition for visibleActions={allActions}. What is allActions?

billsaysthis•2y ago

I posted that also https://discord.com/channels/1143209406037758065/1149368215357640824/1149386764545433682

bill_da_golfer•2y ago

No, you posted export const ANALYTICS_VISIBLE_ACTIONS = [. That's not allActions

billsaysthis•2y ago

yes, it's the same thing

bill_da_golfer•2y ago

So I'm assuming you have allActions = ANALYTICS_VISIBLE_ACTIONS or something like that somewhere?

billsaysthis•2y ago

yes

Duessa HOP•2y ago

FYI I tested in the playground and I am getting hte menu as expected.

Duessa HOP•2y ago

Following up on this, the meatball menu does not appear in our embedded app even if "visible actions' is not used Please advise? To close this out, it seems it was a change we made in CSS that is hiding the menu 😳 We are working on a fix.

Gaming

Programming

Hello I ve noticed in our embedded app

Did you find this page helpful?