nvidia/ublue-os-nvidia-addons.spec at ma...

I'm looking for some feedback on this line: https://github.com/ublue-os/nvidia/blob/main/ublue-os-nvidia-addons.spec#L33

I've copied this spec file into the akmods PR above, and this line disables the repo files installed by the

ublue-os-nvidia-addons

ublue-os-nvidia-addons

RPM. I don't like it because it makes it hard for me to consume this RPM downstream and know the default state of said repo files.

I want to remove the line, but happy to entertain reasons why to keep...

even if i remove the line, i can certainly still disable those repos after using them in the nvidia image. ... thoughts?

GitHub

nvidia/ublue-os-nvidia-addons.spec at main · ublue-os/nvidia

Fedora variants with built-in Nvidia drivers. Contribute to ublue-os/nvidia development by creating an account on GitHub.

bshermanOP•8/25/23, 2:46 AM

I've made that change here:
https://github.com/ublue-os/akmods/pull/53/commits/cf1a5c627984ac134a26c84a7701cb174ceb1e69

bshermanOP•8/25/23, 3:07 AM

@Switches join me here for feedback

Switches•8/25/23, 3:09 AM

hehe ok then. Tbh like I said if it causes issues remove it, it just seems to be a bit wasted imo as supergfxctl is only really used on laptops afaik

bshermanOP•8/25/23, 3:10 AM

yeah, i am pretty sure i'll be removing it and then disabling the repos after i use them in the nvidia image build

Switches•8/25/23, 3:10 AM

sounds like a cleaner way to do it imo...

Switches•8/25/23, 3:11 AM

some of what others suggest imo are very niche and while its a bonus it kinda muddles things

bshermanOP•8/25/23, 3:14 AM

appreciate the feedback. yep, i'm just trying to keep it simple

Switches•8/25/23, 3:15 AM

best way. We have the custom images for people who want to make these kinds of changes and fleek...