discord.js - Imagine ❄•2y ago

Bad typings

export type RESTPutAPIGuildMemberResult = APIGuildMember | never;

export type RESTPutAPIGuildMemberResult = APIGuildMember | never;

must be

export type RESTPutAPIGuildMemberResult = APIGuildMember | undefined;

export type RESTPutAPIGuildMemberResult = APIGuildMember | undefined;

7 Replies

d.js toolkit•2y ago

- What's your exact discord.js npm list discord.js and node node -v version? - Not a discord.js issue? Check out #other-js-ts. - Consider reading #how-to-get-help to improve your question! - Explain what exactly your issue is. - Post the full error stack trace, not just the top part! - Show your code! - Issue solved? Press the button!

thegoatOP•2y ago

in discord-api-types

Syjalo•2y ago

In discord-api-types never means an HTTP 204 response. As you can see in the docs it can respond with that. undefined will be used if the response is undefined. 204 is nothing at all which in TypeScript never is.

thegoatOP•2y ago

https://www.typescriptlang.org/play?#code/JYWwDg9gTgLgBAbzgQQAoEkDiBXYAbAEwFkBTEAIxKjgF84AzKCEOAcgOAGcBjaAgWgCGYYPxgBPMCU4B6AG4BGAAysAUKpIAPSLDgSpcAEoBRAMoAVVNhhosuQqQpVD07HngBeFBhz5iZSmoAHzgAOxI5KgBudTwSeChXdzgvJThBTjhsUIBrUIgAd1D0zJMLKxsfe38nKBdONxgY1USG9xiZGQA9AH4WpJgAOkE5QRhBKBi4abhO3tUZ2Zk9AAsuOBBsTngYFaYC9OKqJmo8YBySOEo8QoAaOAAiVsaHuFG8bEv17IISemBwgQ4NBDt47H5HIFgeQAFYkbjwAEwKj0QTcEiDdRaHQ7SSXMqWay2XwOALOAYAdWAuwAqqFfv9ASkwSSalCQj8-gCSARmnEEpTqStOYyecy0hksrl8kUSkYzITKuDSbV6o0qbT6VzAc1nu4NcKtaLeao5n09TADSLuQRhqNxpMFotnS7pmanW7lrt9plBEcoCd7pLsfDkQR1MB6HAABQAQgtAEpEE6LU73XQSHhOJcECmBlMlvMaBGo3GLVajTak7npuWhdbAWnun0M1mc3m2pb65WdU2i0A

TS Playground - An online editor for exploring TypeScript and JavaS...

The Playground lets you write TypeScript or JavaScript online in a safe and sharable way.

Socram09•2y ago

The definition of never for discord-api-types cannot override the utility it has in TypeScript, the result of a union with never will always return the defined type, thus causing confusion for the developer, which should be avoided. shrug

Syjalo•2y ago

You can create an issue on GitHub if you have a suggestion by what to replace never

bludgeoning.angel•2y ago

It should be X | undefined as never has no effect I'm concerned about this

Gaming

Programming

Bad typings