Made a small CSS styled component
I know it's not the biggest thing but I got some feedback about my naming in a question before and I wanted to see if my css structure is better this time.
CSS Code: https://github.com/juandevac/grupo_06_e-commerce/blob/main/public/css/home/footer.css
Any feedback is appreciated! 😸
GitHub
grupo_06_e-commerce/public/css/home/footer.css at main · juandevac/...
Proyecto de e-commerce para Digital House. Curso Full Stack con Node JS. - juandevac/grupo_06_e-commerce
3 Replies
Solution
its tough to judge css without being able to see the page
the only thing ill say is in general its not usually great to use viewport width and height
im also not sure why you have your footer with margin-bottom: 2vh
since youre in this discord ill tell you right now youre gunna get a lot of people who would tell you to use tailwind
(and tbh im one of them. tailwind's pretty great)
Thanks for the feedback!
Well, what unit would you recommend me to use when setting heights and widths instead of viewport?
The reason I used that margin was because I needed to give my footer some height without changing the flow of my footer.
And I do plan to get into tailwind in the future 😄 !