discord.js - Imagine ❄•2y ago

fetching command choices

hihi! i have a bit of a complicated command https://gist.github.com/ash-development/51b240f1db0e10b37994b6024263dc52 i have built this command of a previous one i built, but the main change is the team "option". i am currently getting the below error when trying to load the command:

CombinedPropertyError (1)
  Received one or more errors

  input[0]
  | CombinedPropertyError (2)
  |   Received one or more errors
  |
  |   input.name
  |   | MissingPropertyError > name
  |   |   A required property is missing
  |
  |   input.value
  |   | MissingPropertyError > value
  |   |   A required property is missing

    at ArrayValidator.handle (C:\Users\Ty\IdeaProjects\mainBot\node_modules\@sapphire\shapeshift\dist\index.js:473:70)
    at ArrayValidator.parse (C:\Users\Ty\IdeaProjects\mainBot\node_modules\@sapphire\shapeshift\dist\index.js:212:88)
    at MixedClass.addChoices (C:\Users\Ty\IdeaProjects\mainBot\node_modules\@discordjs\builders\dist\index.js:1763:22)
    at C:\Users\Ty\IdeaProjects\mainBot\src\commands\team.js:16:18
    at MixedClass._sharedAddOptionMethod (C:\Users\Ty\IdeaProjects\mainBot\node_modules\@discordjs\builders\dist\index.js:2080:50)
    at MixedClass.addStringOption (C:\Users\Ty\IdeaProjects\mainBot\node_modules\@discordjs\builders\dist\index.js:2052:17)
    at Object.<anonymous> (C:\Users\Ty\IdeaProjects\mainBot\src\commands\team.js:11:10)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at Module.load (node:internal/modules/cjs/loader:1037:32)

CombinedPropertyError (1)
  Received one or more errors

  input[0]
  | CombinedPropertyError (2)
  |   Received one or more errors
  |
  |   input.name
  |   | MissingPropertyError > name
  |   |   A required property is missing
  |
  |   input.value
  |   | MissingPropertyError > value
  |   |   A required property is missing

    at ArrayValidator.handle (C:\Users\Ty\IdeaProjects\mainBot\node_modules\@sapphire\shapeshift\dist\index.js:473:70)
    at ArrayValidator.parse (C:\Users\Ty\IdeaProjects\mainBot\node_modules\@sapphire\shapeshift\dist\index.js:212:88)
    at MixedClass.addChoices (C:\Users\Ty\IdeaProjects\mainBot\node_modules\@discordjs\builders\dist\index.js:1763:22)
    at C:\Users\Ty\IdeaProjects\mainBot\src\commands\team.js:16:18
    at MixedClass._sharedAddOptionMethod (C:\Users\Ty\IdeaProjects\mainBot\node_modules\@discordjs\builders\dist\index.js:2080:50)
    at MixedClass.addStringOption (C:\Users\Ty\IdeaProjects\mainBot\node_modules\@discordjs\builders\dist\index.js:2052:17)
    at Object.<anonymous> (C:\Users\Ty\IdeaProjects\mainBot\src\commands\team.js:11:10)
    at Module._compile (node:internal/modules/cjs/loader:1159:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1213:10)
    at Module.load (node:internal/modules/cjs/loader:1037:32)

any help would be greatly appreaciated ^~^

Gist

team.js

GitHub Gist: instantly share code, notes, and snippets.

39 Replies

d.js toolkit•2y ago

• What's your exact discord.js npm list discord.js and node node -v version? • Post the full error stack trace, not just the top part! • Show your code! • Explain what exactly your issue is. • Not a discord.js issue? Check out #useful-servers.

Amgelo•2y ago

I'm guessing somehow your teamName is undefined on line 46 you could try adding a few console logs to check what exactly is going on also I'd really recommend caching that csv, parsing it on every execution could go wrong easily

ashieOP•2y ago

if i log the teamName in console it looks fine to me Hmmge

ideas on what the best way of doing that would be? 😅

Amgelo•2y ago

just in case you could execute fetchTeamChoices() and save it to a variable outside of your builder, log that variable, and then pass it to the builder check that there isn't an empty object or anything weird somewhere saving it to a variable and if you want refresh it every once on a while using setInterval or with a refresh command if it doesn't change then it's not needed

ashieOP•2y ago

how would i go about executing it? like uhm where sorry i couldn't think of the word lol or are you just saying to do it to test it

Amgelo•2y ago

before your exports

const choices = fetchTeamChoices();
console.log(choices); 

module.exports = {
    data: new SlashCommandBuilder()
        .setName("teamrank")
        .setDescription("View the rank of a team.")
        .addStringOption((option) =>
            option
                .setName("team")
                .setDescription("Select a team from the list.")
                .setRequired(true)
                .addChoices(choices)
        ),
    run: async (client, interaction) => {
    // etc

const choices = fetchTeamChoices();
console.log(choices); 

module.exports = {
    data: new SlashCommandBuilder()
        .setName("teamrank")
        .setDescription("View the rank of a team.")
        .addStringOption((option) =>
            option
                .setName("team")
                .setDescription("Select a team from the list.")
                .setRequired(true)
                .addChoices(choices)
        ),
    run: async (client, interaction) => {
    // etc

ashieOP•2y ago

ah! ope

Promise { <pending> }

Promise { <pending> }

that would probably be it skiestThinking

Amgelo•2y ago

oh well it makes sense for it to return a promise now that I notice it lol is there a reason why you needed to wrap it on a promise?

ashieOP•2y ago

nope not at all tbh i didn't even give it a thought LOL

Amgelo•2y ago

at first glance it looks like it should work without wrapping it

ashieOP•2y ago

the only issue is the reject and resolve stuff

ashieOP•2y ago

https://gist.github.com/ash-development/84b22dda0338d85e7d50f6c93ad9a840

Gist

new team.js

GitHub Gist: instantly share code, notes, and snippets.

ashieOP•2y ago

we have some sort of progress just removing the promise didn't work but this is working better?

ashieOP•2y ago

message.txt

Amgelo•2y ago

you could probably achieve it with a callback then, but I think that'd overcomplicate it even more the easiest way would probably be to just fetch it before registering your command, so choices is already available by the time you need it and probably also the cleanest since it's basically caching it ^^

ashieOP•2y ago

so basically what i did in the new gist right? or am i misunderstanding LOL

Amgelo•2y ago

oh yeah but you should probably throw an error instead of returning it, since that's what you had before already

ashieOP•2y ago

like on line 56?

Amgelo•2y ago

your callback should just have a single parameter throw an error instead on lines 60 and 66 also instead of saving the choices you could save the entire result and just fill choices with that you can then just use that saved result on your run logic

ashieOP•2y ago

okie got it got it took a second to get my head around that LOL hmmm im trying to figure out the best way to do that because i also have to format it into the { name: "", value: "" } format as Hmmge

Amgelo•2y ago

do you have an example of what the object's schema looks like?

ashieOP•2y ago

ths csv im pulling from? or do you mean what "choices" is becoming

Amgelo•2y ago

the csv

ashieOP•2y ago

Amgelo•2y ago

I mean like the object itself okay now I see by looking at the library's npm description you should be able to just map it since it returns an array

ashieOP•2y ago

yeah thats why im confused on why its erroring out because its an array LOL like is this not what you are why are you mad at KekDoge

d.js docs•2y ago

SlashCommandBuilder#addStringOption() Adds a string option

Amgelo•2y ago

seems like it takes a single option oh wrong one

ashieOP•2y ago

https://discordjs.guide/slash-commands/advanced-creation.html#choices

discord.js Guide

Imagine a guide... that explores the many possibilities for your discord.js bot.

d.js docs•2y ago

SlashCommandIntegerOption#addChoices() Adds multiple choices for this option

ashieOP•2y ago

If you have too many choices to display (the maximum is 25), you may prefer to provide dynamic choices based on what the user has typed so far. This can be achieved using autocomplete.

me when im blind

Amgelo•2y ago

yeah also it doesn't take an array, it's a rest parameter

ashieOP•2y ago

it looks like this is what i need lol https://discordjs.guide/slash-commands/autocomplete.html#enabling-autocomplete

discord.js Guide

Imagine a guide... that explores the many possibilities for your discord.js bot.

ashieOP•2y ago

im completely blind love that for me

Amgelo•2y ago

should be .addChoices(...choices) autocomplete would also work, take in mind that it just makes it so that your bot receives an AutocompleteInteraction when a user tries to autocomplete you need to listen to that event and handle it (aka sort out what team the user is trying to type and respond)

ashieOP•2y ago

got it got it it would be much easier to use add choices but i have WAY more than 25 choices lol

Amgelo•2y ago

yeah also now that I think of it it would be better for that refreshing logic I was mentioning before since choices are "hardcoded" inside the command's data you would need to update the command every time you want to add choices which isn't really a feasible choice

ashieOP•2y ago

you so much for your help!! ill play around with this and see what i can accomplish

Amgelo•2y ago

Gaming

Programming

fetching command choices