supergfxctl
so, just for reference, this is what i suspected... the copr repo file is getting set to disabled before the install command runs, which we can see here
I'm still trying to sort out why and where though.
8 Replies
Yeah, I have no idea why that would be. All of the other repos stay enabled
OH! I see!
so... you copied the pattern which was there already, which makes sense...
but... the RPM spec for
ublue-os-nvidia-addons*.rpm
actually disables all it's included repo files before putting them into the archive for distribution...
so this line adds an enabled repo file: https://github.com/ublue-os/nvidia/blob/main/install.sh#L22-L23
but this overwrites it with a disabled version: https://github.com/ublue-os/nvidia/blob/main/install.sh#L31
so i'm thinking of how to most simply do the right thing here
if we want to use packages.json, i'd prefer to go all in, and put all package names in there, but we can't really, since several of them are kernel and nvidia driver version specific
so, maybe we just don't use the packages.json pattern for this, and instead keep it simple
i'm thinking the latter idea is cleanest.... so I'll PR this and ask you to approveHah SWEET. Nice job finding that. I wouldn't have noticed that in a million years
thanks, i've just worked with these repos and the scripts enough that i've faced this kind of problem before 🙂
Yeah, I really need to learn more about spec files considering they're used everywhere
it's not spec file specific, just happens that in the
ublue-os-nvidia-addons.spec
we run a sed command to disable all the extra repos
https://github.com/ublue-os/nvidia/blob/main/ublue-os-nvidia-addons.spec#L35GitHub
fix: install supergfxctl-plasmoid by bsherman · Pull Request #121 ·...
Corrects a problem where this was failing to install due to the ublue-os-nvidia-addons RPM disabling the required COPR repo.
Fixes #99 again
FYI @EyeCantCU
Oh, all right. That makes sense