Topics

C#•2y ago

❔ WPF data binding

Hello, I'm new into wpf developing. I'm trying to bind textbox's data to a property, but it seems to work only for getter, not setter. when I manually set the property and run the app, the textbox is filled by the property. But when, in the app, I change textbox's data, it doesn't update the property. Can somebody help me ?

33 Replies

HimmDawg•2y ago

Can you show us, how you set up the binding? 🙂

PetitKinderOP•2y ago

I will try to do so

PetitKinderOP•2y ago

PetitKinderOP•2y ago

here a textbox's Text is binded to a Scene property

PetitKinderOP•2y ago

PetitKinderOP•2y ago

here is the property

PetitKinderOP•2y ago

PetitKinderOP•2y ago

here is my view

PetitKinderOP•2y ago

PetitKinderOP•2y ago

and that's the viewModel sorry that's a bit messy

HimmDawg•2y ago

And where are you setting the DataContext? Furthermore, your second Textbox in ShotTheme.xaml binds to shot which does not exist. You'll have to use Shot. And your Shot property will need to notify the UI when something changed as well Instead of

public string Scene
{
  get 
  {
    return _scene;
  }
  set
  {
    _scene = value;
    OnPropertyChanged();
  }
}

public string Scene
{
  get 
  {
    return _scene;
  }
  set
  {
    _scene = value;
    OnPropertyChanged();
  }
}

You can use

public string Scene
{
  get => _scene;
  set => SetProperty(ref _scene, value);
}

public string Scene
{
  get => _scene;
  set => SetProperty(ref _scene, value);
}

Or even drop the entire property and do just this

[ObservableProperty]
private string _scene;

[ObservableProperty]
private string _scene;

The last example creates some source-generated files, so you'll still be able to use Scene in your code and XAML, even though you never specifically declared it. This makes it more readable :) So for Shot you'll have to choose one of those 3 ways to notify your UI The same applies for Environment So I checked the docs. So most of the time, bindings have a default value for UpdateSourceTrigger of PropertyChanged. However this doesn't apply to textboxes. So you'll 1.) have to set the binding mode of your bindings to TwoWay and then, you'll have to set the UpdateSourceTrigger of your binding to PropertyChanged

PetitKinderOP•2y ago

which one ? In the view I'm setting the datacontext for the ShotListViewModel, but I don't know if this is the one you talking about isn't it what the OnpropertyChanged element is for ? for this last exemple, do I need to generate the ObservableProperty class ?

HimmDawg•2y ago

No, I meant the ShotTheme. Are you setting the datacontext there? Yes, but only for Shot. All other properties wont notify the UI because they dont have this in your VM No, it's part of the CommunityToolkit 🙂 you can use it in every class that derives from ObservableObject ah wait.. i noticed that theres no CommunityToolkit in your usings. ObservableObject is your own implementation then? In that case you'll have to go with the first way ^^

PetitKinderOP•2y ago

Using the lambda sign ? I need to set dataContext for a theme ? Because I'm declaring a resourceDictionary for it in the app.xaml

HimmDawg•2y ago

Nah, just go the same way as with your Scene property I falsely assumed that ObservableObject comes from a package that is widely used in WPF. That package also has a class called ObservableObject and it provides the same functionality. They just added a few extras If you want to bind stuff to the controls in it, then you'll have to have some sort of DataContext

PetitKinderOP•2y ago

How do I do so ? What I don't understand, is that the binding works half way

HimmDawg•2y ago

That's because

Furthermore, your second Textbox in ShotTheme.xaml binds to shot which does not exist. You'll have to use Shot.

Binding to Properties is case-sensitive

PetitKinderOP•2y ago

Yeah I know, I was working first on Scene. But scene doesn't work neither

HimmDawg•2y ago

Side-question. Do you really have to bind data into a theme?

PetitKinderOP•2y ago

Well the listView is composed of items defined in the ShotTheme But I suppose it's possible to bind into a theme When the element scene of the object is set in the code, it's working because the textbox is set with the value defined. So the binding is working. But when in the app I modify the property, if I print scene in the output window, the value isn't updated.

HimmDawg•2y ago

No, I meant: Do you specifically have to bind stuff in your theme? 😄 You'd still need a DataContext to bind data. A resource dictionary can't have a datacontext

PetitKinderOP•2y ago

I need to bind the text of textbox which are in the theme, so idk how I can do without it.

HimmDawg•2y ago

Try to replace the controltemplate with a datatemplate and specify the datatype

PetitKinderOP•2y ago

yeah it seems to be a problem around the template, but I'm not used to xaml enough to re-template everything, I think I will have to do some research

HimmDawg•2y ago

So tl;dr If you just replace "ControlTemplate" with "DataTemplate", you can then assign a DataType to the template. If you do that, you can then use the properties of this datatype in Bindings of control properties within the template

PetitKinderOP•2y ago

But can I do that within a style ? because my listView has the property ItemContentStyle set to the style ShotTheme so I need a style, but if I'm right I can't use dataTemplate in a style I will try using a dataTrigger outside Style well no I can't do that

Accord•2y ago

Was this issue resolved? If so, run /close - otherwise I will mark this as stale and this post will be archived until there is new activity.

PetitKinderOP•2y ago

Any other ideas ? i'm stuck

HimmDawg•2y ago

What about changing the TargetType to ListView and the targeted property of the setter to ItemContainerStyle ? Then you can use DataTemplate

<ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
                    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
                    xmlns:models="clr-namespace:WPF_Tests.Models">
    <Style TargetType="{x:Type ListView}">
        <Style.Setters>
            <Setter Property="ItemContainerStyle" >
                <Setter.Value>
                    <Style TargetType="ListViewItem">
                        <Setter Property="ContentTemplate">
                            <Setter.Value>
                                <DataTemplate DataType="models:ShotModel">
                                    <StackPanel Orientation="Horizontal">
                                        <TextBox Text="{Binding Scene}" />
                                        <TextBox Text="{Binding Shot}" />
                                        <TextBox Text="{Binding Environment}" />
                                    </StackPanel>
                                </DataTemplate>
                            </Setter.Value>
                        </Setter>
                    </Style>
                </Setter.Value>
            </Setter>
        </Style.Setters>
    </Style>
</ResourceDictionary>

<ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
                    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
                    xmlns:models="clr-namespace:WPF_Tests.Models">
    <Style TargetType="{x:Type ListView}">
        <Style.Setters>
            <Setter Property="ItemContainerStyle" >
                <Setter.Value>
                    <Style TargetType="ListViewItem">
                        <Setter Property="ContentTemplate">
                            <Setter.Value>
                                <DataTemplate DataType="models:ShotModel">
                                    <StackPanel Orientation="Horizontal">
                                        <TextBox Text="{Binding Scene}" />
                                        <TextBox Text="{Binding Shot}" />
                                        <TextBox Text="{Binding Environment}" />
                                    </StackPanel>
                                </DataTemplate>
                            </Setter.Value>
                        </Setter>
                    </Style>
                </Setter.Value>
            </Setter>
        </Style.Setters>
    </Style>
</ResourceDictionary>

PetitKinderOP•2y ago

I've tried like that

<ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
                    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
                    xmlns:model="clr-namespace:ProductionSheets.MVVM.Model">

    <ResourceDictionary.MergedDictionaries>
        <ResourceDictionary Source="TextboxTheme.xaml"/>
    </ResourceDictionary.MergedDictionaries>

    <Style TargetType="{x:Type ListViewItem}"
           x:Key="ShotTheme">
        <Style.Setters>
            <Setter Property="ContentTemplate">
                <Setter.Value>
                    <DataTemplate DataType="model:ShotModel">
                        
                        <Border Background="Transparent"
                                    BorderThickness="0,2,0,2"
                                    BorderBrush="#cccccc"
                                    Margin="20,0,20,0">

                            <StackPanel Orientation="Horizontal">
                                <TextBox Style="{StaticResource TextboxTheme}"
                                             Name="Scene"
                                             Text="{Binding Scene}"/>

                                <TextBox Style="{StaticResource TextboxTheme}"
                                             Name="Shot"
                                             Text="{Binding Shot}"/>
                                <TextBox Style="{StaticResource TextboxTheme}"
                                             Name="Environment"
                                             Text="{Binding Environment}"/>
                            </StackPanel>

                        </Border>
                        
                    </DataTemplate>
                </Setter.Value>
            </Setter>

        </Style.Setters>
    </Style>
</ResourceDictionary>

<ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
                    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
                    xmlns:model="clr-namespace:ProductionSheets.MVVM.Model">

    <ResourceDictionary.MergedDictionaries>
        <ResourceDictionary Source="TextboxTheme.xaml"/>
    </ResourceDictionary.MergedDictionaries>

    <Style TargetType="{x:Type ListViewItem}"
           x:Key="ShotTheme">
        <Style.Setters>
            <Setter Property="ContentTemplate">
                <Setter.Value>
                    <DataTemplate DataType="model:ShotModel">
                        
                        <Border Background="Transparent"
                                    BorderThickness="0,2,0,2"
                                    BorderBrush="#cccccc"
                                    Margin="20,0,20,0">

                            <StackPanel Orientation="Horizontal">
                                <TextBox Style="{StaticResource TextboxTheme}"
                                             Name="Scene"
                                             Text="{Binding Scene}"/>

                                <TextBox Style="{StaticResource TextboxTheme}"
                                             Name="Shot"
                                             Text="{Binding Shot}"/>
                                <TextBox Style="{StaticResource TextboxTheme}"
                                             Name="Environment"
                                             Text="{Binding Environment}"/>
                            </StackPanel>

                        </Border>
                        
                    </DataTemplate>
                </Setter.Value>
            </Setter>

        </Style.Setters>
    </Style>
</ResourceDictionary>

but it's still not working I will try your version nope, not working So maybe the problem is somewhere else ok so I know where the problem is from. In the shotTheme above, I'm defining a couple of textBox. They all share the same style TextboxTheme. If I remove the style, the binding of Scene is working, the value is updated correctly. What I don't understand is why, with the theme, it's not working.

PetitKinderOP•2y ago

message.txt

PetitKinderOP•2y ago

maybe it's because I'm redefining the Textbox' Style. How can I tell the textBox's Text property of TextboxTheme = textBox's Text property of ShotTheme ?

Accord•2y ago

Was this issue resolved? If so, run /close - otherwise I will mark this as stale and this post will be archived until there is new activity.

We are a programming server aimed at coders discussing everything related to C# (CSharp) and .NET.

54KMembers

View on Discord

Did you find this page helpful?