28 Replies
hmm... Ididn't add anything that refresh it that much :d....
FYI, it doesn't matter if I load
firefox-mv3-dev via web-ext or onto Firefox directly as a temporary addonThis issue... I'm not sure what' causing it lol xD
in what condition does it happen?
I run
I load Firefox, load a temp addon, go to
about:addons and make sure that the ext has the permission to run on https://www.youtube.com
When I toggle on the host permission, the background script goes crazyhmmm
when you toggle host permission, what does ff do?
does it like.. inject the script at that time?
This
No
what do you mean by toggle host permission btw
Initially, the bottom toggle is off
No idea why
hmmm
optional permission :d....
that's a MV2 quirk
what if you just move that host_perm over to the mv3 format?
I mean, in the prod manifest it should look like
yeah it should right :d
Though in this specific ext I don't actually send any requests to YouTube but only need it in the content script
it only occurs when you toggle that permission on/off right?
Is there like any need for it at all :d
Yeah I think so
What if you just.. remove the perm :d
Well, if I don't toggle it on, the only way for it run on the web page is by clicking on the icon on the top right corner
And well the point is to see the behavior as soon as the web page loads like a normal extension
Sadly I need to go to sleep 🙃
If the issue can't be fixed by the weekend, I guess I'll just resort to good ol' loading the prod version
I.e. change code ➡️ build ➡️ re-load ➡️ test ➡️ repeat
My key wondering is that.. is this a plasmo bug or a firefox bug? xd....
@avi12 can you make a quick reprod with least minimal amount of code :d
Def a Plasmo bug
It has never occurred to me on Firefox before
The problem is back on track, this time in
0.85.0Hmmmm
might be related to this PR?
I couldn't bother continuing testing on Firefox so I quickly installed Opera
GitHub
unmount react root by veedeo · Pull Request #893 · PlasmoHQ/plasmo
Details
This PRs add a proper React's root.unmount() logic so React components destructor will be called as expected
Code of Conduct
I agree to follow this project's Code of Conduct
I ag...
but.. that's on react
xd
What does it have to do with the constantly reloading background script on Firefox?
it's the only thing that touched csui iirc
So you're suggesting that a similar PR needs to be made for Svelte CSUI?
if you look at the diff between the 2 versions: https://github.com/PlasmoHQ/plasmo/compare/v0.84.2...v0.85.0
GitHub
Comparing v0.84.2...v0.85.0 · PlasmoHQ/plasmo
🧩 The Browser Extension Framework. Contribute to PlasmoHQ/plasmo development by creating an account on GitHub.
there's... barely anything related to bgsw xD