Stardust XR•17mo ago

protostar - tests failing

    Finished test [unoptimized + debuginfo] target(s) in 0.07s
     Running unittests src/lib.rs (target/debug/deps/protostar-e14b68abae2a9f7f)

running 4 tests
test xdg::test_get_icon_path ... FAILED
test xdg::test_parse_desktop_file ... ok
test xdg::test_get_desktop_files ... ok
test xdg::test_render_svg_to_png ... ok

failures:

---- xdg::test_get_icon_path stdout ----
[src/xdg.rs:239] &icon_paths = []
thread 'xdg::test_get_icon_path' panicked at 'assertion failed: icon_paths.contains(&RawIconType::Png(PathBuf::from(\"/usr/share/icons/hicolor/16x16/apps/krita.png\")))', src/xdg.rs:242:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    xdg::test_get_icon_path

test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s

error: test failed, to rerun pass `--lib`

    Finished test [unoptimized + debuginfo] target(s) in 0.07s
     Running unittests src/lib.rs (target/debug/deps/protostar-e14b68abae2a9f7f)

running 4 tests
test xdg::test_get_icon_path ... FAILED
test xdg::test_parse_desktop_file ... ok
test xdg::test_get_desktop_files ... ok
test xdg::test_render_svg_to_png ... ok

failures:

---- xdg::test_get_icon_path stdout ----
[src/xdg.rs:239] &icon_paths = []
thread 'xdg::test_get_icon_path' panicked at 'assertion failed: icon_paths.contains(&RawIconType::Png(PathBuf::from(\"/usr/share/icons/hicolor/16x16/apps/krita.png\")))', src/xdg.rs:242:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace


failures:
    xdg::test_get_icon_path

test result: FAILED. 3 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.04s

error: test failed, to rerun pass `--lib`

56 Replies

Nova•17mo ago

do you have krita installed? we needed some icon to test

Saphira Kai•17mo ago

krita? uh yeah

Nova•17mo ago

ok then @Viola (Nicola) can you help fix this? also... we really need to just refactor protostar entirely we have like 3 versions of it the tech debt is insane we were rushing to get it done for the talk

Saphira Kai•17mo ago

haha yeah

Viola (Nicola)•17mo ago

uhm yeah, can you ping me in 2 days please, so I'll be home to fix it

Nova•17mo ago

oh ok!

Viola (Nicola)•17mo ago

alr, I've merged @Bon Echo 's branch together to mine and now it should be possibile to merge without conflicts to the original protostar repo. (ofc nothing works right now, but I'm working on fixing it) @Nova quick question

            let model = Model::create(
                parent,
                t,
                &ResourceID::new_namespaced("protostar", "hexagon/hexagon"),
            )?;
            let model_part = model.model_part("??????").unwrap();
            model_part
                .set_material_parameter("color", MaterialParameter::Color([0.0, 1.0, 1.0, 1.0]))?;

            let model = Model::create(
                parent,
                t,
                &ResourceID::new_namespaced("protostar", "hexagon/hexagon"),
            )?;
            let model_part = model.model_part("??????").unwrap();
            model_part
                .set_material_parameter("color", MaterialParameter::Color([0.0, 1.0, 1.0, 1.0]))?;

where do I get the model_part relative path of the model?

Nova•17mo ago

check the app_grid branch I've done it already

Viola (Nicola)•17mo ago

okay I've checked that out, but

                .model_part("Hex")
                .unwrap()
                .set_material_parameter("color", MaterialParameter::Color(color))

                .model_part("Hex")
                .unwrap()
                .set_material_parameter("color", MaterialParameter::Color(color))

the color definately isn't chaning the color of the hex, but the tint of the image

Nova•17mo ago

that's weird... copy the hexagon.glb over? also look in app_grid I modularized the protostar code a bit

Viola (Nicola)•17mo ago

ah sorry, I didn't notice that it changed!

Nova•17mo ago

I didn't either tbh OH I separated by material right

Viola (Nicola)•17mo ago

yup, I'm reading it... more merging to do, yay ! I should have merged it right when the talk had ended, my bad :p

Nova•17mo ago

I didn't want to lose the cartridges so I delayed the merge too

Viola (Nicola)•17mo ago

Yeah, that's in the new todo 2. Untangle the code (eg: make it so that the user can decide sizes, models, etc... ) 3. Implement configuration files in the examples

confy - Rust

Zero-boilerplate configuration management

Gaming

Programming

protostar - tests failing