Kysely•3y ago

Rollback transaction

Hi, I'm trying to figure out if it's possible to intentionally rollback a transaction, the idea is that if one insert into the database ends with certain return value, the whole transaction should end and the insert rolled back. Knex has

trx.rollback

trx.rollback

on the callback parameter, but I couldn't find anything like that on Kysely, am I missing something or is this not yet implemented?

Solution

await sql<void>`rollback`.execute(trx)

await sql<void>`rollback`.execute(trx)

Okay I was doing raw sql badly, this does work at least

Jump to solution

Solution

ladal1•4/13/23, 1:04 PM

await sql<void>`rollback`.execute(trx)

await sql<void>`rollback`.execute(trx)

Okay I was doing raw sql badly, this does work at least

koskimas•4/13/23, 2:38 PM

If you throw an error from the transaction callback, the transaction will be rolled back

koskimas•4/13/23, 2:43 PM

Ugh, there's no way to change the solution. The marked solution is wrong and you shouldn't do that. You'll end up with a and another / once the transaction callback finishes.

ladal1OP•4/17/23, 6:58 PM

Tried to change the solution to yours, personally I still feel like the interface is missing, as ending the transactions by throwing an exception (which has to be caught as it's rethrown) is not the best solution for query builder.

Igal•4/17/23, 9:30 PM

Hey

We've had this in mind, and are considering an alternative API: https://github.com/kysely-org/kysely/issues/257

GitHub

More fine-grained transaction API with savepoints? · Issue #257 · k...

try { const trx = await db.begin().isolationLevel('serializable').execute() await trx.insertInto(...).execute() await trx.savepoint('foobar') try { await trx.updateTable(...).execut...

ladal1OP•4/18/23, 7:09 AM

Awesome, thanks for the reply

We really like Kysely here and really like the direction you're taking it so looking forward to it