Kevin Powell - Community•2y ago

Why is my JS not working?

(JS Fiddle for context: https://jsfiddle.net/qLry5cwx/2/) The js is supposed to display a modal but it appears to not even try to execute. The code still works in another project of mine, from which I ripped all of the code, but not on my new site. I cannot figure out for the life of me why it isn't working. Can someone help me? Cheers

5 Replies

Jochem•2y ago

const downloadBtn = document.querySelector(".download-btn");

const downloadBtn = document.querySelector(".download-btn");

This isn't returning anything because there is no class="download-btn" The console says so:

"<a class='gotoLine' href='#867:1'>867:1</a> TypeError: downloadBtn is null"

"<a class='gotoLine' href='#867:1'>867:1</a> TypeError: downloadBtn is null"

Lord Of InsanityOP•2y ago

The download button is on a different page, but I don't see how that can affect the js for the modal

Jochem•2y ago

because certain errors stop javascript execution the rest of the file never runs because you're trying to set a listener on a non-existent element

Lord Of InsanityOP•2y ago

How can I fix it then?

Jochem•2y ago

gotta fix or prevent that error from occurring, then the rest will work again the quick and dirty method is to do this:

if (downloadBtn) downloadBtn.addEventListener("click", downloadAgain);

if (downloadBtn) downloadBtn.addEventListener("click", downloadAgain);

instead of just

downloadBtn.addEventListener("click", downloadAgain);

downloadBtn.addEventListener("click", downloadAgain);

Gaming

Programming

Why is my JS not working?