C#•16mo ago

❔ Downloading string from webclient isnt responding properly to my if statement.

So im trying to make a version check by grabbing the data from a raw github link, it gets the data but my if statement isnt detecting it properly. Its most likely the downloaded string is breaking or something but i have no clue.

23 Replies

Thinker•16mo ago

Don't use WebClient

Jin•16mo ago

what would i use?

Thinker•16mo ago

HttpClient

FusedQyou•16mo ago

To clarify: HttpClient is the modern webclient and works better for fetching/sending data.

Thinker•16mo ago

HttpClient client = new();
var response = await client.GetAsync(url);
var download = await response.Content.ReadAsStringAsync();

HttpClient client = new();
var response = await client.GetAsync(url);
var download = await response.Content.ReadAsStringAsync();

Axiss•16mo ago

What is VersionText.Text?

Thinker•16mo ago

Probably a WinForms label or something

Axiss•16mo ago

Sure, but what is the value?

Jin•16mo ago

the value is 0.1.3 same goes for the github im just trying to test if the messagebox pops up but it doesnt.

Axiss•16mo ago

Check to see if the string from github has a linefeed or something at the end

Jin•16mo ago

Jin•16mo ago

it didnt.

Axiss•16mo ago

Jin•16mo ago

huh

Axiss•16mo ago

Don't know if that's just chrome view-source UI thing, but check it with the debugger just in case

Jin•16mo ago

yeah in github it does show that but i cant make it one.

Thinker•16mo ago

Try trimming the whitespace first before comparing

Axiss•16mo ago

Another option is parse both into a Version: https://learn.microsoft.com/en-us/dotnet/api/system.version.parse?view=net-6.0

Version.Parse Method (System)

Converts the specified read-only span of characters that represents a version number to an equivalent Version object.

Jin•16mo ago

Trimming worked!

Axiss•16mo ago

Comparing raw strings it's always a good idea to trim them. Very easy to accidently get non-visible whitespace in there screwing with you

Jin•16mo ago

Alright, something new i learned 🙂

Axiss•16mo ago

I still recommending parsing them into a Version, it will make the comparison easier No need to roll your own

Accord•16mo ago

Was this issue resolved? If so, run /close - otherwise I will mark this as stale and this post will be archived until there is new activity.

Gaming

Programming

❔ Downloading string from webclient isnt responding properly to my if statement.