C#•3y ago

❔ slide bug in csharp script in unity

im making a game in unity and i have a bug in my script where my character glides over the ground when i hold Space + left or right + and then let go of left or right

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class Smoovement : MonoBehaviour
{
    public float walkSpeed;
    public float moveInput;
    public bool isGrounded;
    private Rigidbody2D rb;
    public LayerMask groundmask;
    public float jumplength;
    public PhysicsMaterial2D bounceMat, normalMat;
    public bool canJump = true;
    public float jumpValue = 0.0f;

    
    public float distance = 0.6f;
    public LayerMask wallLayer;
    public bool isTouchingWallL = false;
    public bool isTouchingWallR = false;




    // Start is called before the first frame update
    void Start()
    {
        rb = gameObject.GetComponent<Rigidbody2D>();
        
    }

    // Update is called once per frame
    void Update()
    {
        moveInput = Input.GetAxisRaw("Horizontal");

        if(jumpValue == 0.0f && isGrounded){
        rb.velocity = new Vector2(moveInput * walkSpeed, rb.velocity.y);
        }
        isGrounded = Physics2D.OverlapBox(new Vector2(gameObject.transform.position.x, gameObject.transform.position.y - 0.5f),
        new Vector2(0.9f, 0.4f), 0f, groundmask);

        isTouchingWallR = Physics2D.Raycast(transform.position, Vector2.right, distance, wallLayer);
        isTouchingWallL = Physics2D.Raycast(transform.position, Vector2.left, distance, wallLayer);


        if(jumpValue >= 0 && !isGrounded && (isTouchingWallL || isTouchingWallR))
        {
            rb.sharedMaterial = bounceMat;
        }else
        {
            rb.sharedMaterial = normalMat;
        }


        
        if(Input.GetKey("space") && isGrounded && canJump)
        {
            jumpValue += 0.3f;
        
        }

        if(Input.GetKeyDown("space") && isGrounded && canJump)
        {
            rb.velocity = new Vector2(0.0f, rb.velocity.y);
           
        }

        if(jumpValue >= jumplength && isGrounded)
        {
            float tempx = moveInput * walkSpeed;
            float tempy = jumpValue;
            rb.velocity = new Vector2(tempx, tempy);
            Invoke("ResetJump", 0.3f);
            
        }
        
        if(Input.GetKeyUp("space")){
            if(isGrounded){
                rb.velocity = new Vector2(moveInput * walkSpeed, jumpValue);
                jumpValue = 0.0f;
            }
            canJump = true;
        }
        if(jumpValue == 0){
            canJump = true;
        }


    }

    void ResetJump()
    {
        canJump = false;
        jumpValue = 0;
        

    }

    void OndrawnGizmosSelected()
    {
        Gizmos.color = Color.green;
        Gizmos.DrawCube(new Vector2(gameObject.transform.position.x, gameObject.transform.position.y - 0.5f), new Vector2(0.9f, 0.2f));

    }
}

using System.Collections;
using System.Collections.Generic;
using UnityEngine;

public class Smoovement : MonoBehaviour
{
    public float walkSpeed;
    public float moveInput;
    public bool isGrounded;
    private Rigidbody2D rb;
    public LayerMask groundmask;
    public float jumplength;
    public PhysicsMaterial2D bounceMat, normalMat;
    public bool canJump = true;
    public float jumpValue = 0.0f;

    
    public float distance = 0.6f;
    public LayerMask wallLayer;
    public bool isTouchingWallL = false;
    public bool isTouchingWallR = false;




    // Start is called before the first frame update
    void Start()
    {
        rb = gameObject.GetComponent<Rigidbody2D>();
        
    }

    // Update is called once per frame
    void Update()
    {
        moveInput = Input.GetAxisRaw("Horizontal");

        if(jumpValue == 0.0f && isGrounded){
        rb.velocity = new Vector2(moveInput * walkSpeed, rb.velocity.y);
        }
        isGrounded = Physics2D.OverlapBox(new Vector2(gameObject.transform.position.x, gameObject.transform.position.y - 0.5f),
        new Vector2(0.9f, 0.4f), 0f, groundmask);

        isTouchingWallR = Physics2D.Raycast(transform.position, Vector2.right, distance, wallLayer);
        isTouchingWallL = Physics2D.Raycast(transform.position, Vector2.left, distance, wallLayer);


        if(jumpValue >= 0 && !isGrounded && (isTouchingWallL || isTouchingWallR))
        {
            rb.sharedMaterial = bounceMat;
        }else
        {
            rb.sharedMaterial = normalMat;
        }


        
        if(Input.GetKey("space") && isGrounded && canJump)
        {
            jumpValue += 0.3f;
        
        }

        if(Input.GetKeyDown("space") && isGrounded && canJump)
        {
            rb.velocity = new Vector2(0.0f, rb.velocity.y);
           
        }

        if(jumpValue >= jumplength && isGrounded)
        {
            float tempx = moveInput * walkSpeed;
            float tempy = jumpValue;
            rb.velocity = new Vector2(tempx, tempy);
            Invoke("ResetJump", 0.3f);
            
        }
        
        if(Input.GetKeyUp("space")){
            if(isGrounded){
                rb.velocity = new Vector2(moveInput * walkSpeed, jumpValue);
                jumpValue = 0.0f;
            }
            canJump = true;
        }
        if(jumpValue == 0){
            canJump = true;
        }


    }

    void ResetJump()
    {
        canJump = false;
        jumpValue = 0;
        

    }

    void OndrawnGizmosSelected()
    {
        Gizmos.color = Color.green;
        Gizmos.DrawCube(new Vector2(gameObject.transform.position.x, gameObject.transform.position.y - 0.5f), new Vector2(0.9f, 0.2f));

    }
}

FusedQyou•1/4/23, 4:14 PM

Maybe it has to do with your code not being consistently formatted and there being loose spaces, brackets and all that

FusedQyou•1/4/23, 4:14 PM

In all seriousness though, this could very much cause mistakes

FusedQyou•1/4/23, 4:14 PM

Sound slike movement input is not being read if the player jumped

SmikkelbakjeOP•1/4/23, 4:19 PM

i tried cleaning it up
i have no idea how to fix this i have sat here a couple of hours trying to find solutions

lemminglion•1/4/23, 4:23 PM

rb.velocity = new Vector2(moveInput * walkSpeed, jumpValue); is possibly wrong in your use case here. When you do this its immediately overriding the horizontal (sliding) momentum by setting a new velocity directly. Its not ideal to set velocity directly unless that's exactly what you need to do.
Instead, use AddForce https://docs.unity3d.com/ScriptReference/Rigidbody2D.AddForce.html
The line you want is likely: rb.AddForce(rb.transform.up * jumpValue);

Llemminglion rb.velocity = new Vector2(moveInput * walkSpeed, jumpValue); is possibly wrong i...

SmikkelbakjeOP•1/4/23, 4:29 PM

if i replace
rb.velocity = new Vector2(moveInput * walkSpeed, jumpValue); with rb.AddForce(rb.transform.up * jumpValue);
it still does the same thing

lemminglion•1/4/23, 4:31 PM

I would try replacing all the with AddForce calls. You will need to adjust the multipliers (in this case WalkSpeed) to possibly much bigger numbers as AddForce imparts energy to the rigidbody as though something hit it in X direction

SmikkelbakjeOP•1/4/23, 4:41 PM

changed them all to rb.AddForce
the player is now on iceskates

lemminglion•1/4/23, 4:42 PM

Yep thats more 'normal' In the Rigidbody in Unity's inspector, increase the drag

lemminglion•1/4/23, 4:42 PM

That's probably 0 if you've never changed it

SmikkelbakjeOP•1/4/23, 4:46 PM

yea

lemminglion•1/4/23, 4:47 PM

So depending on how you want your character to move, you have to balance the amount of force being added vs the amount of drag. There's quite a few ways to do it so its more about trying different solutions until you get one that feels right

SmikkelbakjeOP•1/4/23, 4:47 PM

the jump has became very inconsistand and it doesnt move left or right anymore

SmikkelbakjeOP•1/4/23, 4:52 PM

im trying to figure out why but cant

lemminglion•1/4/23, 4:53 PM

So there are a lot of things going on in that script, some of which from what I can see of your game isn't required for what you're wanting to do. Give me a few mins I'll write up some example code

SmikkelbakjeOP•1/4/23, 4:53 PM

ok thanks!

SmikkelbakjeOP•1/4/23, 4:56 PM

i will be back in ~1 hour

lemminglion•1/4/23, 5:24 PM

Not as feature complete as yours, it lacks the wall finding stuff. However I think that's doing what you wanted

You may have to adjust the values in the inspector as I was just doing it with a 1x1 cube

PlayerController.cs2.15KB

SmikkelbakjeOP•1/4/23, 5:59 PM

it works but it doesnt have the jump charge things
im gonna try to implement that in your script and see how it works

SmikkelbakjeOP•1/4/23, 6:13 PM

im having a lot of trouble trying to combine them
the player shouldnt be able to move in the air
its a jump king style script

lemminglion•1/4/23, 7:07 PM

Add a grounded check where it starts looking at the velocity sign, that will give you immediate control when grounded but not in the air

lemminglion•1/4/23, 7:08 PM

lemminglion•1/5/23, 12:39 AM

@Smikkelbakje If you're still stuck with this, I can confirm this works kinda like how Jump King does. Its not 1 to 1 but despite how simple it may look its actually a fairly hard jump routine. You will need to configure some gameobjects in the scene to act as Left/Right Walls or Floors via tags. I've sent the sample scene to use it too (it may require updating to whatever version of Unity you have installed)

PlayerController.cs11.72KB

SampleScene.unity18.06KB

lemminglion•1/5/23, 12:41 AM

Its unrefined but implements various things from JumpKing:

walk left/right when not jumping
Jump up
Jump and leap in a direction (assuming the player did it fast enough)
Don't allow air control, once the player is leaping they're stuck leaping in that direction
Kill all momentum when the player touches the ground
Bounce off walls if you hit them

lemminglion•1/5/23, 12:58 AM

Apologies, fixed some issues with jump handling, it needs some tuning of variables but this acts basically the same as Jump King

PlayerController.cs11.92KB

Accord•1/6/23, 1:27 AM

Was this issue resolved? If so, run

/close

/close

otherwise I will mark this as stale and this post will be archived until there is new activity.

using System.Collections; using System.Collections.Generic; using UnityEngine; public class Smoovement : MonoBehaviour { public float walkSpeed; public float moveInput; public bool isGrounded; private Rigidbody2D rb; public LayerMask groundmask; public float jumplength; public PhysicsMaterial2D bounceMat, normalMat; public bool canJump = true; public float jumpValue = 0.0f; public float distance = 0.6f; public LayerMask wallLayer; public bool isTouchingWallL = false; public bool isTouchingWallR = false; // Start is called before the first frame update void Start() { rb = gameObject.GetComponent<Rigidbody2D>(); } // Update is called once per frame void Update() { moveInput = Input.GetAxisRaw("Horizontal"); if(jumpValue == 0.0f && isGrounded) { rb.velocity = new Vector2(moveInput * walkSpeed, rb.velocity.y); } isGrounded = Physics2D.OverlapBox(new Vector2(gameObject.transform.position.x, gameObject.transform.position.y - 0.5f), new Vector2(0.9f, 0.4f), 0f, groundmask); isTouchingWallR = Physics2D.Raycast(transform.position, Vector2.right, distance, wallLayer); isTouchingWallL = Physics2D.Raycast(transform.position, Vector2.left, distance, wallLayer); if(jumpValue >= 0 && !isGrounded && (isTouchingWallL || isTouchingWallR)) { rb.sharedMaterial = bounceMat; } else { rb.sharedMaterial = normalMat; } if(Input.GetKey("space") && isGrounded && canJump) { jumpValue += 0.3f; } if(Input.GetKeyDown("space") && isGrounded && canJump) { rb.velocity = new Vector2(0.0f, rb.velocity.y); } if(jumpValue >= jumplength && isGrounded) { float tempx = moveInput * walkSpeed; float tempy = jumpValue; rb.velocity = new Vector2(tempx, tempy); Invoke("ResetJump", 0.3f); } if(Input.GetKeyUp("space")){ if(isGrounded){ rb.velocity = new Vector2(moveInput * walkSpeed, jumpValue); jumpValue = 0.0f; } canJump = true; } if(jumpValue == 0){ canJump = true; } } void ResetJump() { canJump = false; jumpValue = 0; } void OndrawnGizmosSelected() { Gizmos.color = Color.green; Gizmos.DrawCube(new Vector2(gameObject.transform.position.x, gameObject.transform.position.y - 0.5f), new Vector2(0.9f, 0.2f)); } }

using System.Collections; using System.Collections.Generic; using UnityEngine; public class Smoovement : MonoBehaviour { public float walkSpeed; public float moveInput; public bool isGrounded; private Rigidbody2D rb; public LayerMask groundmask; public float jumplength; public PhysicsMaterial2D bounceMat, normalMat; public bool canJump = true; public float jumpValue = 0.0f; public float distance = 0.6f; public LayerMask wallLayer; public bool isTouchingWallL = false; public bool isTouchingWallR = false; // Start is called before the first frame update void Start() { rb = gameObject.GetComponent<Rigidbody2D>(); } // Update is called once per frame void Update() { moveInput = Input.GetAxisRaw("Horizontal"); if(jumpValue == 0.0f && isGrounded) { rb.AddForce(new Vector2(moveInput * walkSpeed, 0), ForceMode2D.Impulse); } isGrounded = Physics2D.OverlapBox(new Vector2(gameObject.transform.position.x, gameObject.transform.position.y - 0.5f), new Vector2(0.9f, 0.4f), 0f, groundmask); isTouchingWallR = Physics2D.Raycast(transform.position, Vector2.right, distance, wallLayer); isTouchingWallL = Physics2D.Raycast(transform.position, Vector2.left, distance, wallLayer); if(jumpValue >= 0 && !isGrounded && (isTouchingWallL || isTouchingWallR)) { rb.sharedMaterial = bounceMat; } else { rb.sharedMaterial = normalMat; } if(Input.GetKey("space") && isGrounded && canJump) { jumpValue += 2.3f; } if(Input.GetKeyDown("space") && isGrounded && canJump) { rb.AddForce(new Vector2(0, 0), ForceMode2D.Impulse); } if(jumpValue >= jumplength && isGrounded) { float tempx = moveInput * walkSpeed; float tempy = jumpValue; rb.AddForce(new Vector2(tempx, tempy), ForceMode2D.Impulse); Invoke("ResetJump", 0.3f); } if(Input.GetKeyUp("space")){ if(isGrounded){ rb.AddForce(new Vector2(moveInput * walkSpeed, jumpValue), ForceMode2D.Impulse); jumpValue = 0.0f; } canJump = true; } if(jumpValue == 0){ canJump = true; } } void ResetJump() { canJump = false; jumpValue = 0; } void OndrawnGizmosSelected() { Gizmos.color = Color.green; Gizmos.DrawCube(new Vector2(gameObject.transform.position.x, gameObject.transform.position.y - 0.5f), new Vector2(0.9f, 0.2f)); } }