C#•4y ago

❔ Refactor help`

Can this be written as a Linq expression?
I've been trying but I keep failing at it. I'm not as great with Linq...

foreach (Assignment item in _assignments)
{
    foreach (AssignedUser user in item.AssigneeId)
    {
        if (user.UserId != _user.MicrosoftId)
        {
            _assignmentsNotOnUser.Add(item);
        }
    }
}

foreach (Assignment item in _assignments)
{
    foreach (AssignedUser user in item.AssigneeId)
    {
        if (user.UserId != _user.MicrosoftId)
        {
            _assignmentsNotOnUser.Add(item);
        }
    }
}

foreach (Assignment item in _assignments)
{
    foreach (AssignedUser user in item.AssigneeId)
    {
        if (user.UserId != _user.MicrosoftId)
        {
            _assignmentsNotOnUser.Add(item);
        }
    }
}

foreach (Assignment item in _assignments)
{
    foreach (AssignedUser user in item.AssigneeId)
    {
        if (user.UserId != _user.MicrosoftId)
        {
            _assignmentsNotOnUser.Add(item);
        }
    }
}

WhiteBlackGoose•12/8/22, 2:05 PM

Hi. Sure, you can SelectMany on _assignments, select on item.AssigneeId, make a where there, that's it

WhiteBlackGoose•12/8/22, 2:05 PM

Read up on SelectMany a bit

Mmalkav Can this be written as a Linq expression? I've been trying but I keep failing at...

FusedQyou•12/8/22, 3:25 PM

Here you go:

_assignmentsNotOnUser = _assignments
  .Where(x => x.AssigneeIds
    .Any(y => y.UserId != _user.MicrosoftId))
    .ToList();

_assignmentsNotOnUser = _assignments
  .Where(x => x.AssigneeIds
    .Any(y => y.UserId != _user.MicrosoftId))
    .ToList();

FusedQyou•12/8/22, 3:26 PM

Where clause on assignments, gets every assignment where the

any

any

clause equals true.
Any returns true for each AssignedUser that matches user.UserId != _user.MicrosoftIduser.UserId != _user.MicrosoftId.
I finish with a ToList() because I stored them in a list in my test. This might not be needed in your case.

Accord•12/9/22, 3:34 PM

Was this issue resolved? If so, run

/close

/close

otherwise I will mark this as stale and this post will be archived until there is new activity.