41 Replies
lab
labOP•2y ago
Thanks for the report- do you have any log before that error block? Also can I see a verbose version of the log? (use pnpm dev --verbose)) I'm investigated the issue and it's likely due to the parcel upgrade, so I'm triage with upstream atm it's related to this: https://github.com/parcel-bundler/parcel/issues/6892
YAGPDB.xyz
YAGPDB.xyz•2y ago
Gave +1 Rep to @holden
lab
labOP•2y ago
Also I recall you're using css modules, what other feature of plasmo are you using? Just wanted to triage and pinpoint the issue I just released a canary version with the bundler upgraded to align with parcel's. If you got a chance please try it out and lmk if the error's gone! (to use canary, simply swap out the version in package.json with canary) parcel bundler related LOC: https://github.com/parcel-bundler/parcel/blob/v2/packages/packagers/js/src/ScopeHoistingPackager.js#L784 @holden let's continue here We've seen this issue before, it's related to the asset bundle size I think... how big is your dev bundle? Also can you share the log for pnpm build --verbose Just released another canary, can you try again [email protected] @holden Do you use any package that might polyfill system nodejs package? for example do you do anything that might import os, buffer, punycode etc?
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
Arcane
Arcane•2y ago
@holden has reached level 3. GG!
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
this is very helpful - narrowed it down to the transformer I will get another canary patch up sometime tmr there's a bug with 0.59.x regarding the release tag oh boy.... Can you try out [email protected] when you got a chance
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
@holden can you take a look at the tree of .plasmo/gen-assets as well as the chrome-mv3.plasmo.manifest.json file inside .plasmo Would be very helpful to see the content of these The latest canary fixed a problem with how plasmo build was using the wrong env when bundling for prod, which I thought would explain why you're getting the assset skipped/not found error. However, that doesn't seem to be the case :d....
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
hmmm.. ok interesting - your manifest file does not have the default_popup So after it load the default_icon, the framework then look into compiling the default popup, to which it couldn't find the entry in your manifest I think ^ disregard the above. A couple of the example I have also doesn't have the default_popup and it worked just fine @holden when ur up, can you update to 0.59.2-alpha.4 and run plasmo build --verbose again <= I can't reproduce with any of the existing example so I just added more logging location, hoping to narrow it down further
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
Alright so we're clear it's in the packaer territory @holden can you show me the content of your tabs directory I think the issue that I nailed down is related to the web accessible resource reconciling Also does it work if you remove tabs from the wars list? And why was tabs needed to be inside the wars list (for iframe?)? Just updated canary with .5 which has some logic that check for entry file copying into wars pls try it out and lmk if it fixed the issue. If not Imma place more verbose log and we will further narrow down this issue
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
interesting.... the only other place where this error could occur would be in the bunder, but it didn't throw at the bundler but at the packager :d.....
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
hmm, you have an overriding html if you remove that html does it work? (just temporary)
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
interesting.... oh with 0.59.0 we shipped a new feature that enable resolving TSPath so you can actually use the paths config in the tsconfig to point directly to your shared modules which can reduce the bundle size for your shared bundle as well maybe you might want to try that and remove the alias field
lab
labOP•2y ago
GitHub
feat: support tsconfig paths by jlalmes · Pull Request #285 · Plasm...
Details Add support for paths in tsconfig.json in Parcel 2. Parcel issue: parcel-bundler/parcel#4936 Resolution: https://github.com/zachbryant/parcel-resolver-tspaths closes https://discord.com/c...
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
yup I think so, there's a setting related to this in the bundler Try the latest canary again - I bumped the bundle limit by an order of magnitude, let's see if that make any difference
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
@holden lmk if you got a chance to test out canary.6, I can't quite replicate this issue on my end xd... I think I found a solution to this problem - the latest Parcel bundler has a bug within its resolver. A patch was recently published so I will try to use their nightly version and see if that work
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
yeah, I think after trying everything, it is def not on our side but the parcel-core upstream. I'm a bit busy today but will get another canary to test by Thursday
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
a new canary is up (0.59.3-alpha.0) - pls test. I bumped parcel to canary hopefully the patch merged into core works
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
darn it this is one quirk with parcel... they wanted to be modular but their version checking makes the whole system fragile, coupled with the fact that their nightly versioning does not follow semver so this is kind of a catch-22..... Worst come to shove I'll prob just fork parcel/core lol @holden just released a new canary Please test and lmk if you still see the assets issue!
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
Arcane
Arcane•2y ago
@holden has reached level 4. GG!
lab
labOP•2y ago
that's rip... I was hoping the new patch on Parcel would fix this issue what's inside that chart.helpers module I wonder and this exact same module is working with 0.55.0? The only other thing I can think of that would cause this issue would be either the new tsconfig path resolver or the native module resolver
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
interesting so 0.58 works do you have anything special in the tsconfig?
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
hmm I see, do you also use that with the alias prop in the package.json ?
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
these 2s have fundamentally changed in 0.59.x - the tsconfig paths now superceed the alias for path-specific import. New docs: https://docs.plasmo.com/customization/alias hmmm, I wonder if you remove shared from alias, and keep just shared/* in your tsconfig would that work? (the hope is that parcel should know to crawl up your monorepo for those modules)
Unknown User
Unknown User•2y ago
Message Not Public
Sign In & Join Server To View
lab
labOP•2y ago
yw!
Want results from more Discord servers?
Add your server