C#•2y ago

❔ Task.WhenAll does not work without Task.Run inside

Inside a task, _pathFinder.FindPath is not called. returnFirstPath is false (Task.WhenAll) but if I change list.Add(new Task<PathResult>(action)); to list.Add(Task.Run(action));, it works. Another question, I should use Task.Run to be sure it runs in different threads and get results faster?

    for (var j = 0; j < roadPoints.Length; j++)
                {
                    var j1 = j;
                    Func<PathResult> action = () =>
                    {
                        var pathResult = _pathFinder.FindPath
                        (
                            sourcePoint,
                            setting.SearchRange,
                            roadPoints[j1],
                            CheckTarget,
                            CheckObstacle,
                            ComputeWeight
                        );
                        return pathResult;
                    };
                    list.Add(new Task<PathResult>(action));
                }

                PathResult pathResult;
                if (returnFirstPath)
                {
                    pathResult = await await Task.WhenAny(list);
                }
                else
                {
                    var pathResults = await Task.WhenAll(list);
                    pathResult = pathResults.MinBy(p => p.Path.Length);
                }

    for (var j = 0; j < roadPoints.Length; j++)
                {
                    var j1 = j;
                    Func<PathResult> action = () =>
                    {
                        var pathResult = _pathFinder.FindPath
                        (
                            sourcePoint,
                            setting.SearchRange,
                            roadPoints[j1],
                            CheckTarget,
                            CheckObstacle,
                            ComputeWeight
                        );
                        return pathResult;
                    };
                    list.Add(new Task<PathResult>(action));
                }

                PathResult pathResult;
                if (returnFirstPath)
                {
                    pathResult = await await Task.WhenAny(list);
                }
                else
                {
                    var pathResults = await Task.WhenAll(list);
                    pathResult = pathResults.MinBy(p => p.Path.Length);
                }

30 Replies

Unknown User•2y ago

Message Not Public

Gladiator•2y ago

Yes, I said Task.Run is OK but without it, it is not called at all Using await await for Task.WhenAny because it returns Task<Task<>>

Unknown User•2y ago

Message Not Public

Gladiator•2y ago

list.Add(new Task<PathResult>(action)); It is I want to know if I can use Task.WhenAll without Task.Run or not, surely I should be able to use it with simple tasks

Unknown User•2y ago

Message Not Public

Gladiator•2y ago

I have tested, my above code is not called . I have put break points here var pathResult = _pathFinder.FindPath

Unknown User•2y ago

Message Not Public

MODiX•2y ago

tebeco#0205

REPL Result: Success

var roadPoints = new int[] { 1, 2 };
var tasks = roadPoints.Select(roadPoint =>
{
  var isThatActuallyNeeded = roadPoint;
  return Task.Run(() =>
  {
    return isThatActuallyNeeded * 100;
  });
}).ToArray();

await Task.WhenAll(tasks);
(tasks[0].Result, tasks[1].Result)

var roadPoints = new int[] { 1, 2 };
var tasks = roadPoints.Select(roadPoint =>
{
  var isThatActuallyNeeded = roadPoint;
  return Task.Run(() =>
  {
    return isThatActuallyNeeded * 100;
  });
}).ToArray();

await Task.WhenAll(tasks);
(tasks[0].Result, tasks[1].Result)

Result: ValueTuple<int, int>

{
  "item1": 100,
  "item2": 200
}

{
  "item1": 100,
  "item2": 200
}

Compile: 639.115ms | Execution: 99.819ms | React with ❌ to remove this embed.

Gladiator•2y ago

😐

Unknown User•2y ago

Message Not Public

MODiX•2y ago

tebeco#0205

REPL Result: Failure

var roadPoints = new int[] { 1, 2 };
var tasks = roadPoints.Select(roadPoint =>
{
  var isThatActuallyNeeded = roadPoint;
  Task.Run(() =>
  {
    return isThatActuallyNeeded * 100;
  });
}).ToArray();

await Task.WhenAll(tasks);
(tasks[0].Result, tasks[1].Result)

var roadPoints = new int[] { 1, 2 };
var tasks = roadPoints.Select(roadPoint =>
{
  var isThatActuallyNeeded = roadPoint;
  Task.Run(() =>
  {
    return isThatActuallyNeeded * 100;
  });
}).ToArray();

await Task.WhenAll(tasks);
(tasks[0].Result, tasks[1].Result)

Exception: CompilationErrorException

- The type arguments for method 'Enumerable.Select<TSource, TResult>(IEnumerable<TSource>, Func<TSource, TResult>)' cannot be inferred from the usage. Try specifying the type arguments explicitly.

- The type arguments for method 'Enumerable.Select<TSource, TResult>(IEnumerable<TSource>, Func<TSource, TResult>)' cannot be inferred from the usage. Try specifying the type arguments explicitly.

Compile: 638.056ms | Execution: 0.000ms | React with ❌ to remove this embed.

Unknown User•2y ago

Message Not Public

Gladiator•2y ago

What a terrible design It gets Task but it does not work, really shit design OK, thanks dudes

Unknown User•2y ago

Message Not Public

Gladiator•2y ago

If I call Start, it works. Yes, those tasks are required to be started Appreciated

Unknown User•2y ago

Message Not Public

Gladiator•2y ago