C#•3y ago

Is there any benefit to write a Property with a private variable ?

LDami · 2022-09-17T15:36:33.007Z

Why: ```cs private int myVar; public int MyVar { get => myVar; set => myVar = value; } ``` may be better than: ```cs public int MyVar; ``` if we let get and set public ?

Why:

private int myVar;
public int MyVar { get => myVar; set => myVar = value; }

private int myVar;
public int MyVar { get => myVar; set => myVar = value; }

may be better than:

public int MyVar;

public int MyVar;

if we let get and set public ?

26 Replies

Becquerel•3y ago

in most IDEs, you get that useful '1 usage' tag above properties, but not fields

Becquerel•3y ago

additionally, properties are required for a lot of frameworks that require attributes over methods -- such as MVVM frameworks and serialization

yotabit•3y ago

I think that the easiest way to see the reason is to understand that not always you'll just get/set the same value. For example:

private int myVar;
public string MyVar
{
get => myVar.toString();
set => myVar;
}

private int myVar;
public string MyVar
{
get => myVar.toString();
set => myVar;
}

In this case, you return a String, but what you have is an integer

LDamiOP•3y ago

I know that, my question was about if I take the exact same value

yotabit•3y ago

Yes. It's exactly the same value

LDamiOP•3y ago

I forgot about that point, you are right !

Becquerel•3y ago

dp, they mean in the degenerate case where it's the same type with public get/set

LDamiOP•3y ago

There can be difference in some methods calls between variable and properties ? 🤔

Pobiega•3y ago

The most important part is "because now you can change it without breaking things later"

Becquerel•3y ago

a very good point

LDamiOP•3y ago

And is there any convention for when we must use variable instead of property ?

Pobiega•3y ago

The convention is always use properties for public things

Becquerel•3y ago

fields for private implementation details, properties for publicly-exposed stuff

Pobiega•3y ago

in normal C# at least. in unity, its different

Becquerel•3y ago

public class MyClass
{
  private int _myField;
  public int MyProperty { get; set; }
}

public class MyClass
{
  private int _myField;
  public int MyProperty { get; set; }
}

LDamiOP•3y ago

👍 👌 So 'get; set;' without associated private variable is good too ?

Becquerel•3y ago

yep, absolutely fine it's equivalent to writing it out the long way 🙂 you only need the private field if you do more complex stuff

Aeon Vex•3y ago

I'd say in unity properties are still preferred, you just can't really use auto properties if you want to serialize

LDamiOP•3y ago

Like read-only Property ?

Becquerel•3y ago

nope, you can do public int MyProperty { get; } by itself just fine i mean like this

LDamiOP•3y ago

Oh I was thinking about private set; but it's the same, my bad

Becquerel•3y ago

private int myInt;

public MyInt
{
  get => myInt * 2;
  set 
  {
    if (value % 2 == 0) myInt = value;
  }
}

private int myInt;

public MyInt
{
  get => myInt * 2;
  set 
  {
    if (value % 2 == 0) myInt = value;
  }
}

contrived example, but yeah

FroH.LVT•3y ago

Invoke some event on set . Eg

public string Name {get {
  return privateName;

}; set{
  privateName = value;
  InvokeSomeEventHere()
})

public string Name {get {
  return privateName;

}; set{
  privateName = value;
  InvokeSomeEventHere()
})

LDamiOP•3y ago

Will this not trigger an infinite loop when setting Name ?

FroH.LVT•3y ago

ah yes, fixed

LDamiOP•3y ago

Okay, I unserstand ! Thanks 🙂

Gaming

Programming

Is there any benefit to write a Property with a private variable ?